Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on PR naming/labelling convention #2312

Closed
spectranaut opened this issue Aug 12, 2024 · 5 comments · May be fixed by #2319
Closed

Decide on PR naming/labelling convention #2312

spectranaut opened this issue Aug 12, 2024 · 5 comments · May be fixed by #2319
Assignees
@daniel-montalvo
Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Comments

@spectranaut
Copy link
Contributor

Right now, we are using a mix of the PRs starting with a string like [Editorial] and [html-aam], and, we have tags for these things. Maybe we should just do one or the other?
@spectranaut spectranaut added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo Agenda-Editors labels Aug 12, 2024
@spectranaut
Copy link
Contributor Author

Maybe add a github action to add labels?

@spectranaut
Copy link
Contributor Author

Also add information to PR template!

@pkra pkra mentioned this issue Aug 23, 2024
Open
@pkra
Copy link
Member

pkra commented Aug 23, 2024

Maybe add a github action to add labels?

=> #2318

@daniel-montalvo
Copy link
Contributor

@daniel-montalvo to test this on his own fork before merging.

@daniel-montalvo daniel-montalvo self-assigned this Oct 28, 2024
@daniel-montalvo
Copy link
Contributor

The labeler has been failing for a while (my fault) but should be fixed now.

Tested in daniel-montalvo#2 and it automatically assigns spec:accname and spec:core-aam based on the files changed.

@pkra pkra closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-montalvo daniel-montalvo

Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Add naming and labeling conventions to PR template w3c/aria
3 participants
@pkra @spectranaut @daniel-montalvo