-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Illegal CDDL when defining script.RegExpRemoteValue
and script.DateRemoteValue
#881
Comments
RFC 8610 gives the following examples as valid https://datatracker.ietf.org/doc/rfc8610/#:~:text=3.8.5.%20%20Control%20Operators%20.within%20and%20.and
|
I think also my understanding is that RegExpRemoteValue uses |
The grammar in the spec is pretty clear that the only legal combination is TBF, the grammar in the original spec didn't cover the case of Thanks for pointing me to the bit in the spec about |
Hmm, where do the grammar extracts you quoted come from, @shs96c? Looking at the grammar in RFC 9862 that you linked to, I see other definitions for type1 = type2 [S (rangeop / ctlop) S type2]
; space may be needed before the operator if type2 ends in a name
type2 = value
/ typename [genericarg]
/ "(" S type S ")"
/ "{" S group S "}"
/ "[" S group S "]"
/ "~" S typename [genericarg]
/ "&" S "(" S group S ")"
/ "&" S groupname [genericarg]
/ "#" "6" ["." head-number] "(" S type S ")"
/ "#" "7" ["." head-number]
/ "#" DIGIT ["." uint] ; major/ai
/ "#" ; any I don't know if the right-hand side of the assignment is meaningful, but at least it seems to comply with the grammar defined in the RFC? |
The ABNF grammar for parsing CDDL is given in RFC 9682. In this spec, we define
script.RegExpRemoteValue
as:Reading the grammer, the map on the right-hand side of the assignment matches:
That is
"{" S group S "}"
. However, the only match that is allowed an annotator istype2 [S (rangeop / annotator) S type2]
, wheretype2
is defined as:which doesn't match the expression we've used to define the regex remote value. Further, it is not clear what is meant by
.and script.RegExpLocalValue
with this construction as that annotation isn't defined in either RFC 9682 or 8610.We should update the spec so that we only contain conformant CDDL.
The text was updated successfully, but these errors were encountered: