Reworking reordering so it doesn't clear the tree before reordering. Test still passes afterwards :)

Author: weaverryan

lib/model/doctrine/PluginioDoctrineMenuItemTable.class.php

@@ -149,12 +149,6 @@ public function restoreTreeFromNestedArray($arr, ioDoctrineMenuItem $root)
       throw new sfException('ioDoctrineMenuItemTable::restoreTreeFromNestedArray() must be called using a root node.');
     }
 
-    // remove all of the nodes from the tree
-    $this->clearTree($root);
-
-    // reestablish the root
-    $this->getTree()->createRoot($root);
-
     // put the nodes back on
     $this->restoreBranchFromNestedArray(array('menu' => $root, 'children' => $arr));
   }
@@ -172,18 +166,19 @@ public function restoreBranchFromNestedArray($arr)
 
     if (isset($arr['children']))
     {
-      foreach ($arr['children'] as $childArr)
+      // for details on why we do this, see ioDoctrineMenuItem::persistFromMenuArray()
+      $children = array_reverse($arr['children']);
+      foreach ($children as $childArr)
       {
         $child = $this->find($childArr['id']);
-        $child->getNode()->insertAsLastChildOf($parent);
+        $child->getNode()->moveAsFirstChildOf($parent);
 
         // put the child object into the array
         $childArr['menu'] = $child;
         unset($childArr['id']);
 
         // recurse down and ultimately refresh the parent
         $this->restoreBranchFromNestedArray($childArr);
-        $parent->refresh();
       }
     }