-
-
Notifications
You must be signed in to change notification settings - Fork 233
test(e2e): enable native HTML implementation #6505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the default HTML plugin implementation from JavaScript-based ('js') to Rust-based native implementation ('native'). The native implementation produces HTML link tags with a different attribute ordering, placing the href attribute before the rel attribute. All test expectations have been updated to match this new attribute order.
Key Changes
- Changed default
html.implementationfrom'js'to'native'in the core configuration - Updated all HTML link tag assertions in e2e tests to expect the new attribute order (
hrefbeforerel)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/defaultConfig.ts | Changed default HTML implementation from 'js' to 'native' |
| e2e/cases/html/favicon/index.test.ts | Updated test expectations for favicon link tags to match new attribute order |
| e2e/cases/html/app-icon/index.test.ts | Updated test expectations for app icon and manifest link tags to match new attribute order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| outputStructure: 'flat', | ||
| scriptLoading: 'defer', | ||
| implementation: 'js', | ||
| implementation: 'native', |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the default from 'js' to 'native' is a significant breaking change that affects HTML output format. The documentation at line 1605 in types/config.ts states '@default 'js'' which should be updated to reflect this new default value of 'native'.

Summary
This PR is used to test the native HTML implementation, ensuring that all E2E cases can be passed.
Diff
Breaking changes
<%= process.env.ASSET_PREFIX %>is no longer supported, use<%= assetPrefix %>insteadNon-breaking changes
Checklist