fix: sri remote url relative protocol

Author: unknown

crates/rspack_plugin_sri/src/html.rs

@@ -1,6 +1,5 @@
 use std::sync::Arc;
 
-use cow_utils::CowUtils;
 use futures::future::join_all;
 use once_cell::sync::Lazy;
 use regex::Regex;
@@ -173,12 +172,12 @@ async fn process_tag(
     return Ok(None);
   }
 
-  let Some(mut tag_src) = get_tag_src(tag) else {
+  let Some(tag_src) = get_tag_src(tag) else {
     return Ok(None);
   };
 
   // A tag which is not generated by chunks should be skipped
-  if match Url::parse(&tag_src) {
+  let src = if match Url::parse(&tag_src) {
     Ok(url) => url.scheme() == "http" || url.scheme() == "https",
     Err(_) => tag_src.starts_with("//"),
   } {
@@ -188,15 +187,20 @@ async fn process_tag(
     let protocol_relative_public_path = HTTP_PROTOCOL_REGEX.replace(public_path, "").to_string();
     let protocol_relative_tag_src = HTTP_PROTOCOL_REGEX.replace(&tag_src, "").to_string();
     if protocol_relative_tag_src.starts_with(&protocol_relative_public_path) {
-      tag_src = protocol_relative_tag_src
-        .cow_replace(&protocol_relative_public_path, public_path)
-        .into_owned();
+      let tag_src_with_scheme = format!("http:{}", protocol_relative_tag_src);
+      let public_path_with_scheme = if protocol_relative_public_path.starts_with("//") {
+        format!("http:{}", protocol_relative_public_path)
+      } else {
+        protocol_relative_public_path.to_string()
+      };
+      get_asset_path(&tag_src_with_scheme, &public_path_with_scheme)
     } else {
       return Ok(None);
     }
-  }
+  } else {
+    get_asset_path(&tag_src, public_path)
+  };
 
-  let src = get_asset_path(&tag_src, public_path);
   if let Some(integrity) =
     get_integrity_checksum_for_asset(&src, integrities, normalized_integrities).await
   {

packages/rspack/src/builtin-plugin/SubresourceIntegrityPlugin.ts

@@ -200,6 +200,7 @@ export class SubresourceIntegrityPlugin extends NativeSubresourceIntegrityPlugin
 			isUrlSrc = tagSrc.startsWith("//");
 		}
 
+		let src = "";
 		if (isUrlSrc) {
 			if (!publicPath) {
 				return;
@@ -210,16 +211,21 @@ export class SubresourceIntegrityPlugin extends NativeSubresourceIntegrityPlugin
 			);
 			const protocolRelativeTagSrc = tagSrc.replace(HTTP_PROTOCOL_REGEX, "");
 			if (protocolRelativeTagSrc.startsWith(protocolRelativePublicPath)) {
-				tagSrc = protocolRelativeTagSrc.replace(
-					protocolRelativePublicPath,
-					publicPath
+				let tagSrcWithScheme = `http:${protocolRelativeTagSrc}`;
+				let publicPathWithScheme = protocolRelativePublicPath.startsWith("//")
+					? `http:${protocolRelativePublicPath}`
+					: protocolRelativePublicPath;
+				src = relative(
+					publicPathWithScheme,
+					decodeURIComponent(tagSrcWithScheme)
 				);
 			} else {
 				return;
 			}
+		} else {
+			src = relative(publicPath, decodeURIComponent(tagSrc));
 		}
 
-		const src = relative(publicPath, decodeURIComponent(tagSrc));
 		tag.attributes.integrity =
 			this.getIntegrityChecksumForAsset(src) ||
 			computeIntegrity(