Skip to content

Conversation

@ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Dec 1, 2025

This fixes two issues with the types we use in web-features:

  • Types aren't exported, which makes it inconvenient to write code the conforms to web-features's types
  • The types rely on a specific tsconfig, which fails type checking in some configurations.

Fixes #1980. See also Jym77/web-features-ts-esm, which was essential for fixing these issues.

If you want to try this version of the package, check out this branch and follow steps along these lines.
npm install
npm run build
cd packages/web-features
npm pack --pack-destination=$SOME_PACKAGE_WORKSPACE
cd $SOME_PACKAGE_WORKSPACE
npm install web-features-3.*.tgz
# do something with the package, e.g., npm test

Thanks to @Jym77 for the reproduction: https://github.com/Jym77/web-features-ts-esm

Co-authored-by: Jean-Yves Moyen <[email protected]>
@ddbeck ddbeck force-pushed the 1980-export-types branch from 4c63e79 to 5b2dc4e Compare December 1, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web-features doesn't export types gracefully

1 participant