Skip to content

Commit 31fec3e

Browse files
committed
Add explainers
commit cffe2d5 Author: Bramus <[email protected]> Date: Mon Aug 22 15:00:48 2022 +0200 Fix typo commit cc8017d Author: Bramus <[email protected]> Date: Mon Aug 22 14:52:19 2022 +0200 Clarify why `document.documentElement.clientWidth`/`.clientHeight` works commit 2d9a5f2 Author: Bramus <[email protected]> Date: Mon Aug 22 14:31:12 2022 +0200 Fix double example in Layout Viewport explainer commit 6c93be1 Merge: a11d652 84ccf1e Author: Bramus <[email protected]> Date: Mon Aug 22 12:43:41 2022 +0200 Merge branch 'main' into explainers commit a11d652 Author: Bramus <[email protected]> Date: Mon Aug 22 12:42:04 2022 +0200 Add Viewport Units commit 7686a4e Author: Bramus <[email protected]> Date: Mon Aug 22 12:42:00 2022 +0200 Minor rewording commit 4d4180f Author: Bramus <[email protected]> Date: Mon Aug 22 10:37:11 2022 +0200 Fix code examples Indentation commit c24b27b Merge: b2ea114 9ed4f6f Author: Bramus <[email protected]> Date: Thu Aug 18 17:12:38 2022 +0200 Merge branch 'main' into explainers commit b2ea114 Author: Bramus <[email protected]> Date: Thu Aug 18 17:08:46 2022 +0200 More explainers commit 832110e Author: Bramus <[email protected]> Date: Thu Aug 18 17:08:42 2022 +0200 Add illustrations commit 67f1825 Author: Bramus <[email protected]> Date: Thu Aug 18 15:10:25 2022 +0200 More Findings commit 3435bb2 Author: Bramus <[email protected]> Date: Wed Aug 17 21:59:08 2022 +0200 More Findings commit 87c95ea Merge: 1a28015 a202dd7 Author: Bramus <[email protected]> Date: Wed Aug 17 19:28:41 2022 +0100 Merge branch 'main' into findings commit 1a28015 Author: Bramus <[email protected]> Date: Wed Aug 17 19:21:17 2022 +0100 Tests: Clarify that ICB size is taken from document.documentElement commit 1be8789 Author: Bramus <[email protected]> Date: Wed Aug 17 19:21:32 2022 +0100 Findings: ICB + LVP (WIP) commit dc7e49e Author: Bramus <[email protected]> Date: Wed Aug 17 18:59:42 2022 +0100 Rename findings to explainers commit bbb8302 Author: Bramus <[email protected]> Date: Fri Aug 12 02:04:45 2022 +0200 Add more findings placeholders commit f7d5391 Author: Bramus <[email protected]> Date: Fri Aug 12 02:07:03 2022 +0200 Start work on findings: ICB and LVP (WIP)
1 parent 84ccf1e commit 31fec3e

File tree

55 files changed

+549
-7
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+549
-7
lines changed

README.md

+17-5

demos/src/core.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ export { getLayoutViewportValues };
211211
const getICBValues = () => {
212212
// @NOTE: Instead of getting the values through by measuring the root element
213213
// (i.e `document.documentElement,getBoundingClientRect()`), we can use
214-
// `documentElement.clientHeight/clientWidth` which yield the same values
214+
// `documentElement.clientHeight/clientWidth` which yield the correct values.
215+
// These values do not require the ICB to be sized as 100% x 100%.
215216
return {
216217
width: document.documentElement.clientWidth,
217218
height: document.documentElement.clientHeight,

demos/src/individual/icb/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
core.syncVisualViewportValuesToCustomProperties(vvv);
1919

2020
const icbv = core.getICBValues();
21-
core.write(icbv, document.querySelector("#icb-values"), 'icb');
21+
core.write(icbv, document.querySelector("#icb-values"), 'icb (document.documentElement)');
2222

2323
const wv = core.getWindowValues();
2424
core.write(wv, document.querySelector("#window-values"), 'window');

explainers/icb.md

+99
107 KB
86.6 KB

explainers/layout-viewport.md

+100

explainers/scrolling.md

+31

0 commit comments

Comments
 (0)