Skip to content

Commit d6d2256

Browse files
authored
compute pressure: Rename estimate to own_contribution_estimate (#51679)
To match the specification[1], renaming `estimate` parameter to `own_contribution_update` in update_virtual_pressure_source test functions. [1] https://w3c.github.io/compute-pressure/?experimental=1#the-owncontributionestimate-attribute
1 parent 46e74bc commit d6d2256

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

resources/testdriver.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1437,7 +1437,7 @@
14371437
* @param {String} sample - A `virtual pressure state
14381438
* <https://w3c.github.io/compute-pressure/#dom-pressurestate>`_
14391439
* such as "critical".
1440-
* @param {number} estimate - Optional, A `virtual own contribution estimate`
1440+
* @param {number} own_contribution_estimate - Optional, A `virtual own contribution estimate`
14411441
* <https://w3c.github.io/compute-pressure/?experimental=1#the-owncontributionestimate-attribute>`_
14421442
* @param {WindowProxy} [context=null] - Browsing context in which to
14431443
* run the call, or null for the
@@ -1449,8 +1449,8 @@
14491449
* virtual pressure source of the given type does not
14501450
* exist).
14511451
*/
1452-
update_virtual_pressure_source: function(source_type, sample, estimate, context=null) {
1453-
return window.test_driver_internal.update_virtual_pressure_source(source_type, sample, estimate, context);
1452+
update_virtual_pressure_source: function(source_type, sample, own_contribution_estimate, context=null) {
1453+
return window.test_driver_internal.update_virtual_pressure_source(source_type, sample, own_contribution_estimate, context);
14541454
},
14551455

14561456
/**
@@ -1748,7 +1748,7 @@
17481748
throw new Error("create_virtual_pressure_source() is not implemented by testdriver-vendor.js");
17491749
},
17501750

1751-
async update_virtual_pressure_source(source_type, sample, estimate, context=null) {
1751+
async update_virtual_pressure_source(source_type, sample, own_contribution_estimate, context=null) {
17521752
throw new Error("update_virtual_pressure_source() is not implemented by testdriver-vendor.js");
17531753
},
17541754

tools/wptrunner/wptrunner/executors/actions.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -498,8 +498,8 @@ def __init__(self, logger, protocol):
498498
def __call__(self, payload):
499499
source_type = payload["source_type"]
500500
sample = payload["sample"]
501-
estimate = payload["estimate"]
502-
return self.protocol.pressure.update_virtual_pressure_source(source_type, sample, estimate)
501+
own_contribution_estimate = payload["own_contribution_estimate"]
502+
return self.protocol.pressure.update_virtual_pressure_source(source_type, sample, own_contribution_estimate)
503503

504504
class RemoveVirtualPressureSourceAction:
505505
name = "remove_virtual_pressure_source"

tools/wptrunner/wptrunner/executors/executormarionette.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ def setup(self):
721721
def create_virtual_pressure_source(self, source_type, metadata):
722722
raise NotImplementedError("create_virtual_pressure_source not yet implemented")
723723

724-
def update_virtual_pressure_source(self, source_type, sample, estimate):
724+
def update_virtual_pressure_source(self, source_type, sample, own_contribution_estimate):
725725
raise NotImplementedError("update_virtual_pressure_source not yet implemented")
726726

727727
def remove_virtual_pressure_source(self, source_type):

tools/wptrunner/wptrunner/executors/executorwebdriver.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -685,8 +685,8 @@ def create_virtual_pressure_source(self, source_type, metadata):
685685
body.update(metadata)
686686
return self.webdriver.send_session_command("POST", "pressuresource", body)
687687

688-
def update_virtual_pressure_source(self, source_type, sample, estimate):
689-
body = {"sample": sample, "estimate": estimate}
688+
def update_virtual_pressure_source(self, source_type, sample, own_contribution_estimate):
689+
body = {"sample": sample, "own_contribution_estimate": own_contribution_estimate}
690690
return self.webdriver.send_session_command("POST", "pressuresource/%s" % source_type, body)
691691

692692
def remove_virtual_pressure_source(self, source_type):

tools/wptrunner/wptrunner/executors/protocol.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,7 @@ def create_virtual_pressure_source(self, source_type, metadata):
10091009
pass
10101010

10111011
@abstractmethod
1012-
def update_virtual_pressure_source(self, source_type, sample, estimate):
1012+
def update_virtual_pressure_source(self, source_type, sample, own_contribution_estimate):
10131013
pass
10141014

10151015
@abstractmethod

tools/wptrunner/wptrunner/testdriver-extra.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -468,8 +468,8 @@
468468
return create_context_action("create_virtual_pressure_source", context, {source_type, metadata});
469469
};
470470

471-
window.test_driver_internal.update_virtual_pressure_source = function(source_type, sample, estimate, context=null) {
472-
return create_context_action("update_virtual_pressure_source", context, {source_type, sample, estimate});
471+
window.test_driver_internal.update_virtual_pressure_source = function(source_type, sample, own_contribution_estimate, context=null) {
472+
return create_context_action("update_virtual_pressure_source", context, {source_type, sample, own_contribution_estimate});
473473
};
474474

475475
window.test_driver_internal.remove_virtual_pressure_source = function(source_type, context=null) {

0 commit comments

Comments
 (0)