Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDriverTestharnessExecutor should own bidi v. classic decision #50546

Open
gsnedders opened this issue Feb 7, 2025 · 1 comment
Open

WebDriverTestharnessExecutor should own bidi v. classic decision #50546

gsnedders opened this issue Feb 7, 2025 · 1 comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

Currently this is in the ChromeDriverTestharnessExecutor:

require_webdriver_bidi = kwargs.get("browser_settings", {}).get(
"require_webdriver_bidi", None)
if require_webdriver_bidi:
self.protocol_cls = ChromeDriverBidiProtocol
else:
self.protocol_cls = ChromeDriverProtocol

Coming from:

self._require_webdriver_bidi = test.testdriver_features is not None and 'bidi' in test.testdriver_features

I am doubting whether this is the right place for this logic to live; the RFC wasn't in any way Chrome specific, but we do somehow need to know if the browser supports bidi and whether or not we want to enable it.

cc @sadym-chromium

@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run labels Feb 7, 2025
@sadym-chromium
Copy link
Contributor

sadym-chromium commented Feb 11, 2025

Good point. The main motivation to put the specific protocol selector logic in ChromeDriverTestharnessExecutor was to minimize the potential impact on other implementations.

I started drafting solution for the concern in #50626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

2 participants