Skip to content

The Italian Tax calculation strategy should use the system parameter to check for billing or shipping address #18

@lruozzi9

Description

@lruozzi9

Currently, the ItalianTaxCalculationStrategy uses the billing address to check if the taxes should be skipped or not. With Sylius v1.10 or v1.11 a new config parameter has been added sylius_core.shipping_address_based_taxation. This parameter is used to decide if it should be used the billing or shipping address's country to calculate taxes. I think this parameter (that in v1.12 has been replaced by a Channel property) should be injected in the above service and should be used to decide to check the billing or shipping address.
What do you think @webgriffe/wg-devs?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions