Skip to content
This repository was archived by the owner on Dec 22, 2020. It is now read-only.

parse error(s) swallowed #33

Closed
JakobJingleheimer opened this issue Mar 18, 2019 · 2 comments
Closed

parse error(s) swallowed #33

JakobJingleheimer opened this issue Mar 18, 2019 · 2 comments

Comments

@JakobJingleheimer
Copy link
Contributor

The loader catches the parse error and then swallows JSON5's error:

// src/index.js:15
  throw new Error('Error parsing JSON5', (e));

This is not valid as the Error constructor takes only 1 argument: message?: string
@alexander-akait
Copy link
Member

@jshado1 thanks for issue, PR welcome

@JakobJingleheimer
Copy link
Contributor Author

JakobJingleheimer commented Mar 18, 2019 •
edited
Loading

Sure, I have a fix locally. I'll send it over tonight.

JakobJingleheimer added a commit to JakobJingleheimer/json5-loader that referenced this issue Mar 19, 2019
@JakobJingleheimer
Remove try/catch throw to avoid swallowing JSON5 error output
f049f69 
Resolves webpack-contrib#33
@JakobJingleheimer JakobJingleheimer mentioned this issue Mar 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakobJingleheimer @alexander-akait