feat: add stats option#537
Conversation
Expose a stats option to make hot module replacement and other informational messages optional. Only stat presets are supported but the API can be expanded to an object later if useful.
|
So far as I can tell, these errors are false positives due to preexisting security audit failures. |
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
No need, webpack has built-in logger we should migrate on it
|
Thank you for the fast feedback, @evilebottnawi! I'm sorry but I didn't quite understand the feedback. Are you saying to use the Webpack logger API, to abandon this change, or something else? Thank you! |
|
Yes webpack logger API |
|
@evilebottnawi, done (I think). Edit: I tried to mimic the webpack-dev-server implementation and options as the HMR client context is very similar. |
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
We should use built-in webpack logger, not loglever
|
webpack-dev-server@4 migrate on built-in webpack logger |
|
@evilebottnawi, thank you. Is this a good example to base the approach on? |
2 participants
This PR contains a:
Motivation / Use-Case
Expose a stats option to make hot module replacement and other
informational messages optional. Only stat presets are supported but the
API can be expanded to an object later if useful.
Breaking Changes
Additional Info