fix: do not allow empty or invalid node args when spin up child process (#73)

Author: mistic

src/WorkerPool.js

@@ -18,8 +18,12 @@ class PoolWorker {
     this.activeJobs = 0;
     this.onJobDone = onJobDone;
     this.id = workerId;
+
     workerId += 1;
-    this.worker = childProcess.spawn(process.execPath, [].concat(options.nodeArgs || []).concat(workerPath, options.parallelJobs), {
+    // Empty or invalid node args would break the child process
+    const sanitizedNodeArgs = (options.nodeArgs || []).filter(opt => !!opt);
+
+    this.worker = childProcess.spawn(process.execPath, [].concat(sanitizedNodeArgs).concat(workerPath, options.parallelJobs), {
       detached: true,
       stdio: ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'],
     });

test/workerPool.test.js

@@ -41,4 +41,28 @@ describe('workerPool', () => {
     workerPool.terminate();
     expect(workerPool.isAbleToRun()).toBe(false);
   });
+
+  it('should sanitize nodeArgs when spawn a child process', () => {
+    childProcess.spawn.mockClear();
+    childProcess.spawn.mockImplementationOnce(() => {
+      return {
+        stdio: new Array(5).fill(new stream.PassThrough()),
+        unref: jest.fn(),
+      };
+    });
+
+    const workerPool = new WorkerPool({
+      workerNodeArgs: [
+        '--max-old-space-size=1024',
+        '',
+        null,
+      ],
+      workerParallelJobs: 20,
+    });
+
+    expect(() => workerPool.createWorker()).not.toThrow();
+
+    const nonSanitizedNodeArgs = childProcess.spawn.mock.calls[0][1].filter(opt => !opt);
+    expect(nonSanitizedNodeArgs.length).toEqual(0);
+  });
 });