Ensure error and behavior logs are written to database in order (#2540)

Fixes #2539

Author: tw4l

backend/btrixcloud/operator/crawls.py

@@ -878,7 +878,7 @@ async def sync_crawl_state(
             if crawler_running:
                 status.lastActiveTime = date_to_str(dt_now())
 
-            file_done = await redis.lpop(self.done_key)
+            file_done = await redis.rpop(self.done_key)
             while file_done:
                 msg = json.loads(file_done)
                 # add completed file
@@ -887,31 +887,31 @@ async def sync_crawl_state(
                     await redis.incr("filesAdded")
 
                 # get next file done
-                file_done = await redis.lpop(self.done_key)
+                file_done = await redis.rpop(self.done_key)
 
-            page_crawled = await redis.lpop(f"{crawl.id}:{self.pages_key}")
+            page_crawled = await redis.rpop(f"{crawl.id}:{self.pages_key}")
             qa_run_id = crawl.id if crawl.is_qa else None
 
             while page_crawled:
                 page_dict = json.loads(page_crawled)
                 await self.page_ops.add_page_to_db(
                     page_dict, crawl.db_crawl_id, qa_run_id, crawl.oid
                 )
-                page_crawled = await redis.lpop(f"{crawl.id}:{self.pages_key}")
+                page_crawled = await redis.rpop(f"{crawl.id}:{self.pages_key}")
 
-            crawl_error = await redis.lpop(f"{crawl.id}:{self.errors_key}")
+            crawl_error = await redis.rpop(f"{crawl.id}:{self.errors_key}")
             while crawl_error:
                 await self.crawl_ops.add_crawl_error(
                     crawl.db_crawl_id, crawl.is_qa, crawl_error
                 )
-                crawl_error = await redis.lpop(f"{crawl.id}:{self.errors_key}")
+                crawl_error = await redis.rpop(f"{crawl.id}:{self.errors_key}")
 
-            behavior_log = await redis.lpop(f"{crawl.id}:{self.behavior_logs_key}")
+            behavior_log = await redis.rpop(f"{crawl.id}:{self.behavior_logs_key}")
             while behavior_log:
                 await self.crawl_ops.add_crawl_behavior_log(
                     crawl.db_crawl_id, behavior_log
                 )
-                behavior_log = await redis.lpop(f"{crawl.id}:{self.behavior_logs_key}")
+                behavior_log = await redis.rpop(f"{crawl.id}:{self.behavior_logs_key}")
 
             # ensure filesAdded and filesAddedSize always set
             status.filesAdded = int(await redis.get("filesAdded") or 0)