Skip to content

Conversation

@ikreymer
Copy link
Member

@ikreymer ikreymer commented Dec 6, 2025

  • Fixes [Task]: Add new SubscriptionAddMinutes event to subscriptions #3052
  • New SubscriptionAddMinutes event, added via /subscription/add-minutes endpoint, storing total_price, currency, context, oid and minutes added.
  • Remove org/quotas/add endpoint (can readd if needed for superadmin use later)
  • Remove 'context' from OrgQuotasIn, only added from SubscriptionAddMinutes, though keep on OrgQuotasUpdate list on orgs
  • add filtering by 'add-minutes' subscription event type

- handle minutes purchased via SubscriptionAddMin event
- use /subscriptions/add-minutes endpoint to add additional minutes
@ikreymer ikreymer requested review from emma-sg and tw4l December 6, 2025 21:36
@ikreymer ikreymer force-pushed the additional-minutes-addon-purchase--add-sub-add-minutes-events branch from ef8907e to 40abc2d Compare December 7, 2025 19:00
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality/changes/tests look good. I'll defer to you and Emma on the approach but good to have the subscription event and type filtering available

Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me as well!

@emma-sg emma-sg merged commit 399934f into additional-minutes-addon-purchase Dec 8, 2025
24 of 26 checks passed
@emma-sg emma-sg deleted the additional-minutes-addon-purchase--add-sub-add-minutes-events branch December 8, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants