-
Notifications
You must be signed in to change notification settings - Fork 4
Store parse status of all declarations #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 7, 2025
This was
unlinked from
issues
Oct 7, 2025
a172f37 to
db727a7
Compare
This was
linked to
issues
Oct 8, 2025
252f339 to
79a068d
Compare
|
This PR will be parked for a while, see #1028 (comment). |
b05fd3f to
a0cdb07
Compare
7b5e1d7 to
d24b7ea
Compare
d24b7ea to
0b69468
Compare
0b69468 to
a59ef7e
Compare
a59ef7e to
29cdd25
Compare
29cdd25 to
26dadde
Compare
|
In agreement with Edsko, I am putting this on the queue. Two issues are still unresolved: |
47434e7 to
cbbe2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a CI error: https://github.com/well-typed/hs-bindgen/actions/runs/18343147007/job/52243182474?pr=1192
I can not reproduce the error locally, I think because I am using a newer version of LLVM.
Will close
IntroduceSelectedButUnavailablemessage #1037SelectDeclMetawithDeclMeta#1038Finally, this PR is ready for discussion:
QualPrelimDeclIdfails. -> Moved to separate issue Investigate CI issue with LLVM 15 and anonymous declarations of ordinary type #1220.Selectpass.unavailableTransitiveDeps?DeclIndex: Assembly is complicated.DeclIndex: For failures, we do not overwrite existing, previously inserted key-value pairs.EDIT: This PR does not yet solve #1037, there is more work to do (we have to find declarations that we fail to generate bindings for because transitive dependencies are unavailable).