Skip to content

Commit 68a71fd

Browse files
committed
Remove support for Ruby 3.1 and the aligned JRuby 9.4, add support for JRuby 10
- rubycritic.gemspec: update minimum Ruby version to 3.2 - .rubocop.yml: update target Ruby version to 3.2 - CI: drop Ruby 3.1 and jruby 9.4 (Ruby 3.1) - add platform value to the gemspec, and require jar-dependencies version
1 parent 4835a5e commit 68a71fd

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

.github/workflows/main.yml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,14 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
ruby-version:
31-
- '3.1'
3231
- '3.2'
3332
- '3.3'
3433
- '3.4'
3534
experimental: [false]
3635
include:
3736
- ruby-version: 'ruby-head'
3837
experimental: true
39-
- ruby-version: 'jruby-9.4'
38+
- ruby-version: 'jruby-10'
4039
experimental: true
4140
steps:
4241
- uses: actions/checkout@v4
@@ -54,20 +53,18 @@ jobs:
5453
needs: pre_job # skip duplicates
5554
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
5655
runs-on: ubuntu-latest
57-
continue-on-error: ${{ matrix.experimental }}
5856
strategy:
5957
fail-fast: false
6058
matrix:
6159
ruby-version:
62-
- '3.1'
6360
- '3.2'
6461
- '3.3'
6562
- '3.4'
6663
experimental: [false]
6764
include:
6865
- ruby-version: 'ruby-head'
6966
experimental: true
70-
- ruby-version: 'jruby-9.4'
67+
- ruby-version: 'jruby-10'
7168
experimental: true
7269
steps:
7370
- uses: actions/checkout@v4
@@ -79,25 +76,24 @@ jobs:
7976
cache-version: 1
8077
- name: Run Rubocop
8178
run: bundle exec rubocop
79+
continue-on-error: ${{ matrix.experimental }}
8280

8381
Reek:
8482
needs: pre_job # skip duplicates
8583
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
8684
runs-on: ubuntu-latest
87-
continue-on-error: ${{ matrix.experimental }}
8885
strategy:
8986
fail-fast: false
9087
matrix:
9188
ruby-version:
92-
- '3.1'
9389
- '3.2'
9490
- '3.3'
9591
- '3.4'
9692
experimental: [false]
9793
include:
9894
- ruby-version: 'ruby-head'
9995
experimental: true
100-
- ruby-version: 'jruby-9.4'
96+
- ruby-version: 'jruby-10'
10197
experimental: true
10298
steps:
10399
- uses: actions/checkout@v4
@@ -109,27 +105,25 @@ jobs:
109105
cache-version: 1
110106
- name: Run Reek
111107
run: bundle exec rake reek
108+
continue-on-error: ${{ matrix.experimental }}
112109

113110
Minitest:
114111
needs: pre_job # skip duplicates
115112
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
116113
runs-on: ubuntu-latest
117-
continue-on-error: ${{ matrix.experimental }}
118114
strategy:
119115
fail-fast: false
120116
matrix:
121117
ruby-version:
122-
- '3.1'
123118
- '3.2'
124119
- '3.3'
125120
- '3.4'
126121
experimental: [false]
127122
include:
128123
- ruby-version: 'ruby-head'
129124
experimental: true
130-
- ruby-version: 'jruby-9.4'
125+
- ruby-version: 'jruby-10'
131126
experimental: true
132-
133127
steps:
134128
- uses: actions/checkout@v4
135129
- name: Set up Ruby ${{ matrix.ruby-version }}
@@ -140,6 +134,7 @@ jobs:
140134
cache-version: 1
141135
- name: Run Unit tests
142136
run: bundle exec rake test
137+
continue-on-error: ${{ matrix.experimental }}
143138

144139
MarkdownLint:
145140
needs: pre_job # skip duplicates

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ AllCops:
1111
- 'tmp/**/*'
1212
- 'vendor/**/*'
1313
- 'gemfiles/*'
14-
TargetRubyVersion: 3.1
14+
TargetRubyVersion: 3.2
1515

1616
Metrics/BlockLength:
1717
Enabled: false

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...main)
22

3+
* [CHANGE] Drop support for Ruby 3.1.x and JRuby 9.4 (by [@faisal][])
34
* [CHANGE] Bump minitest dependency. (by [@faisal][])
45

56
# v4.10.0 / 2025-07-30 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...v4.10.0)

rubycritic.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ require 'rubycritic/version'
77
Gem::Specification.new do |spec|
88
spec.name = 'rubycritic'
99
spec.version = RubyCritic::VERSION
10+
spec.platform = RUBY_PLATFORM == 'java' ? Gem::Platform::JAVA : Gem::Platform::RUBY
1011
spec.authors = ['Guilherme Simoes']
1112
spec.email = ['[email protected]']
1213
spec.description = 'RubyCritic is a tool that wraps around various static analysis gems ' \
1314
'to provide a quality report of your Ruby code.'
1415
spec.summary = 'RubyCritic is a Ruby code quality reporter'
1516
spec.homepage = 'https://github.com/whitesmith/rubycritic'
1617
spec.license = 'MIT'
17-
spec.required_ruby_version = '>= 3.1.0'
18+
spec.required_ruby_version = '>= 3.2.0'
1819

1920
spec.files = [
2021
'CHANGELOG.md',
@@ -45,6 +46,7 @@ Gem::Specification.new do |spec|
4546
spec.add_development_dependency 'aruba', '~> 2.3.1', '>= 2.3.1'
4647
spec.add_development_dependency 'bundler', '>= 2.0.0'
4748
if RUBY_PLATFORM == 'java'
49+
spec.add_development_dependency 'jar-dependencies', '~> 0.5.5'
4850
spec.add_development_dependency 'pry-debugger-jruby'
4951
else
5052
spec.add_development_dependency 'byebug', '~> 12.0', '>= 10.0'

0 commit comments

Comments
 (0)