Potential undesired behavior in SplitDocumentDockable.

[pmichale]

Hi, thanks for the hard work on the library!

I'll cut right to the chase. I've either found behavior that's undesirable or I don't understand the intent behind it.

I assumed that the ID of a given tool or document dock is supposed to be unique, as I am then using it to locate the specific component. Like so: dock = dockLayoutFactory.GetDockable<EditorDocumentDock>(id);

I have run into an issue where I am unable to reasonably differentiate between document docks if the users decides to split the document dock into two.

Here's the relevant code from my Layout Factory that creates the new document dock and sets the ID:

public override IDocumentDock CreateDocumentDock() => CreateNewDocumentDock();

private EditorDocumentDock CreateNewDocumentDock()
{
    _index += 1;
    var documentDock = serviceProvider.CreateScope().ServiceProvider.GetRequiredService<EditorDocumentDock>();
    documentDock.Id = "Files"+_index;
    documentDock.Title = "Files";

    Console.WriteLine("Creating document dock: " + _index);

    return documentDock;
}

I have found that the ID is overwritten inside DockManager.cs within this library and is set based on the sourceDocumentDock:

private void SplitDocumentDockable(IDockable sourceDockable, IDock sourceDockableOwner, IDock targetDock, DockOperation operation)
{
    if (targetDock.Factory is not { } factory)
    {
        return;
    }

    var targetDocumentDock = factory.CreateDocumentDock();
    targetDocumentDock.Title = nameof(IDocumentDock);
    targetDocumentDock.VisibleDockables = factory.CreateList<IDockable>();
    if (sourceDockableOwner is IDocumentDock sourceDocumentDock)
    {
        // HERE IS THE LINE I FIND PROBLEMATIC
        targetDocumentDock.Id = sourceDocumentDock.Id;
        targetDocumentDock.CanCreateDocument = sourceDocumentDock.CanCreateDocument;

        if (sourceDocumentDock is IDocumentDockContent sourceDocumentDockContent
            && targetDocumentDock is IDocumentDockContent targetDocumentDockContent)
        {
            targetDocumentDockContent.DocumentTemplate = sourceDocumentDockContent.DocumentTemplate;
        }
    }
    factory.MoveDockable(sourceDockableOwner, targetDocumentDock, sourceDockable, null);
    factory.SplitToDock(targetDock, targetDocumentDock, operation);
}

Am I approaching this in an unexpected way, or is this an oversight. Thanks!