Fix a bug that ignored read and write permissions on profiles

Author: Mael Alle

ajax/config.php

@@ -21,6 +21,15 @@
     exit;
 }
 
+// Check if user has READ right on the plugin
+if (!Session::haveRight('plugin_wikitsemanticschat_config', READ)) {
+    echo json_encode([
+        'success' => false,
+        'error'   => 'Access denied',
+    ]);
+    exit;
+}
+
 // Get configuration
 $config = Config::getConfig();
 

setup.php

@@ -8,7 +8,7 @@
 use GlpiPlugin\Wikitsemanticschat\Config;
 use GlpiPlugin\Wikitsemanticschat\Profile;
 
-define('PLUGIN_WIKITSEMANTICSCHAT_VERSION', '1.0.0');
+define('PLUGIN_WIKITSEMANTICSCHAT_VERSION', '1.0.1');
 // Minimal GLPI version, inclusive
 define('PLUGIN_WIKITSEMANTICSCHAT_MIN_GLPI_VERSION', '10.0.0');
 // Maximum GLPI version, exclusive
@@ -33,25 +33,26 @@ function plugin_init_wikitsemanticschat(): void {
        return;
    }
 
-    // Add JavaScript on all pages for logged-in users only
+   // Register plugin classes (always needed for profile management)
    if (Session::getLoginUserID()) {
-       // Load plugin configuration and main script
-       $PLUGIN_HOOKS[Hooks::ADD_JAVASCRIPT]['wikitsemanticschat'] = [
-           'public/js/config.js.php',
-           'public/js/wikitsemanticschat.js'
-       ];
-
-       // Register plugin classes
        Plugin::registerClass(Config::class);
        Plugin::registerClass(
            Profile::class,
            ['addtabon' => 'Profile']
        );
 
        // Configuration page in Setup > Plugins
-      if (Session::haveRight('config', UPDATE)) {
-         $PLUGIN_HOOKS['config_page']['wikitsemanticschat'] = 'front/config.form.php';
-      }
+       if (Session::haveRight('config', UPDATE)) {
+           $PLUGIN_HOOKS['config_page']['wikitsemanticschat'] = 'front/config.form.php';
+       }
+
+       // Add JavaScript only for users with READ right
+       if (Session::haveRight('plugin_wikitsemanticschat_config', READ)) {
+           $PLUGIN_HOOKS[Hooks::ADD_JAVASCRIPT]['wikitsemanticschat'] = [
+               'public/js/config.js.php',
+               'public/js/wikitsemanticschat.js'
+           ];
+       }
    }
 }
 

wikitsemanticschat.xml

@@ -92,6 +92,11 @@
             <compatibility>~11.0.0</compatibility>
             <download_url>https://github.com/wikit-ai/GLPI-Semantics-Chat/releases/download/v2.0.0/wikitsemanticschat-2.0.0.tar.bz2</download_url>
         </version>
+        <version>
+            <num>1.0.1</num>
+            <compatibility>~10.0.0</compatibility>
+            <download_url>https://github.com/wikit-ai/GLPI-Semantics-Chat/releases/download/v1.0.1/wikitsemanticschat-1.0.1.tar.bz2</download_url>
+        </version>
         <version>
             <num>1.0.0</num>
             <compatibility>~10.0.0</compatibility>