-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS package doesn't support images #10946
Comments
Hi! Sorry for the delay, I just saw that the topic came back on Discord so it reminded me of this issue. We already discussed how we could write a recipe for this in #10317 (and in Talking & Doc'ing) but the conclusion was that it was too difficult to document properly because the generation is heavily dependent on the user project. Images won't work, but neither will links if they are relative. So to include the full post, you should think about images, relative links, styles, scripts, and other elements that might be relevant to your project. For example, you may have unnecessary elements for an RSS feed (those used only for styling or interaction on your website) that should be removed. It's a bit tricky to document and involves a fair amount of code that can be difficult to follow. So I'm not sure what we can do here... But, you can get inspiration from existing projects such as: |
Thank you @ArmandPhilippot! I was able to implement the feed manually by following the first example that you shared. My impression is that this recipe handles the most common use cases and would encourage you / Astro team to include a convenience function that wraps it. I have noticed that any custom presentation beyond basic Markdown is better off solved on the layout level via additional frontmatter data, so that the feed can remain manageable. My code in case anyone finds it useful:
|
So, just to figure out where we landed here:
Would those two things be helpful here? |
|
Alright, thanks Armand for careful analysis here! Seems like the best we can do is update this section in docs to something like....:
What do y'all think? |
Looks perfect to me! 🙌🏽 Much better than what I tried on my side. 😅 |
Thanks everyone! I've updated with the appropriate
|
@sarah11918 i would like to work on this |
Astro Info
If this issue only occurs in one browser, which browser is a problem?
No response
Describe the Bug
Including full post content is RSS 101. The recipe to that doesn't produce valid image paths.
What's the expected result?
The recipe should generate content with valid image paths. Ideally it would with MDX too.
Link to Minimal Reproducible Example
https://docs.astro.build/en/recipes/rss/#including-full-post-content
Participation
The text was updated successfully, but these errors were encountered: