intrusive counter: check deletion refcount after chmpxchg

wjakob · Feb 14, 2024 · 47abc72 · 47abc72
1 parent ba0ed85
commit 47abc72
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/include/nanobind/intrusive/counter.inl b/include/nanobind/intrusive/counter.inl
@@ -104,12 +104,13 @@ bool intrusive_counter::dec_ref() const noexcept {
                         "intrusive_counter::dec_ref(%p): reference count "
                         "underflow!", (void *) this);
                 abort();
-            } else if (v == 3) {
-                return true;
             }
 
             if (!NB_ATOMIC_CMPXCHG(&m_state, &v, v - 2))
                 continue;
+
+            if (v == 1)
+                return true;
         } else {
             intrusive_dec_ref_py((PyObject *) v);
         }