sftp client example for Renesas RX72N #847
Conversation
dgarske
requested review from
dgarske and
ejohnstown
and removed request for
dgarske
src/wolfsftp.c
Outdated
| }; | ||
|
|
||
| #if defined(__CCRX__) | ||
| static struct fd_entry fd_pool[WOLFSSH_FATFS_MAX_FILES] = {0}; |
There was a problem hiding this comment.
C guarantee's the memory is zero'd so just remove the = {} please and special CCRX logic
There was a problem hiding this comment.
Removed = {} and CCRX logic
|
|
||
| case ID_EXTINFO_S: | ||
| #if defined(__CCRX__) | ||
| ret = WSNPRINTF0(str, strSz, "Server extensions KEX"); |
There was a problem hiding this comment.
Can you share what the warning was? Sometimes you can solve this just by changing the macro to: #define WSNPRINTF snprintf
There was a problem hiding this comment.
C:/workspace/wolfssh/src/ssh.c(3202):E0520029:Expected an expression
| #define NO_WOLFSSL_DIR | ||
| #define NO_WOLFSSL_STUB | ||
| /* for compilers not allowed dynamic size array */ | ||
| #define NO_DYNAMIC_ARRAY |
There was a problem hiding this comment.
I don't recognize this macro. I think you mean WOLFSSL_SP_NO_DYN_STACK or HAVE_EMPTY_AGGREGATES 0
There was a problem hiding this comment.
I based my configuration on the settings in user_settings.h. I tried to find out whether the definition existed in past versions, but I couldn’t find it. So I just removed the macro. WOLFSSL_SP_NO_DYN_STACK is already defined in the file.
| #define ECC_TIMING_RESISTANT | ||
| #define WC_RSA_BLINDING | ||
|
|
||
| #define FP_MAX_BITS 4096 |
There was a problem hiding this comment.
With SP math FP_MAX_BITS is not used... You need SP_INT_BITS 2048 which is likely default. FP_MAX_BITS only applies to USE_FAST_MATH and only if WOLFSSL_SP_MATH is not defined.
There was a problem hiding this comment.
Thanks. I also needed to add the WOLFSSL_SP_NO_3072 definition.
| #define USE_CERT_BUFFERS_2048 | ||
| #define SIZEOF_LONG_LONG 8 | ||
| /* Warning: define your own seed gen */ | ||
| #define WOLFSSL_GENSEED_FORTEST |
There was a problem hiding this comment.
I don't like that we are using the GENSEED_FORTEST by default...
miyazakh
dismissed stale reviews from JacobBarthelmeh and ejohnstown
via
c50eec4
- renamed wolfstp_util.c to wolfsftp_util.c - removed unnecessary if condition
- enable TSIP - clean up user_settings.h
miyazakh
force-pushed
the
sftpclient_RX72N
branch
from
cbf22d1 to
0165b1e
Compare
5 participants
Add simple sftp client example working on Renesas RX72N