Merge pull request #9286 from holtrop/rust-wc-ecc

Rust wrapper: add wolfssl::wolfcrypt::ecc module

Author: dgarske

doc/dox_comments/header_files/ecc.h

@@ -122,7 +122,7 @@ int wc_ecc_make_key_ex(WC_RNG* rng, int keysize, ecc_key* key, int curve_id);
     slot.
 
     \return 0 Returned on success.
-    \return ECC_BAD_ARG_E Returned if rng or key evaluate to NULL
+    \return ECC_BAD_ARG_E Returned if key is NULL
     \return BAD_FUNC_ARG Returned if the supplied key is not a valid ecc_key.
     \return MEMORY_E Returned if there is an error allocating memory while
     computing the public key
@@ -172,11 +172,10 @@ int wc_ecc_make_pub(ecc_key* key, ecc_point* pubOut);
     an existing private component.  If pubOut is supplied, the computed public
     key is stored there, else it is stored in the supplied ecc_key public
     component slot.  The supplied rng, if non-NULL, is used to blind the private
-    key value used in the computation.  If rng is NULL, an ephemeral rng is
-    instantiated internally.
+    key value used in the computation.
 
     \return 0 Returned on success.
-    \return ECC_BAD_ARG_E Returned if rng or key evaluate to NULL
+    \return ECC_BAD_ARG_E Returned if key is NULL
     \return BAD_FUNC_ARG Returned if the supplied key is not a valid ecc_key.
     \return MEMORY_E Returned if there is an error allocating memory while
     computing the public key

wolfcrypt/src/ecc.c

@@ -4083,7 +4083,9 @@ int wc_ecc_mulmod(const mp_int* k, ecc_point *G, ecc_point *R, mp_int* a,
 /**
  * Allocate a new ECC point (if one not provided)
  * use a heap hint when creating new ecc_point
- * return an allocated point on success or NULL on failure
+ * @return 0 on success
+ * @return BAD_FUNC_ARG for invalid arguments
+ * @return MEMORY_E on failure to allocate memory
 */
 static int wc_ecc_new_point_ex(ecc_point** point, void* heap)
 {
@@ -11812,15 +11814,14 @@ static int wc_ecc_import_raw_private(ecc_key* key, const char* qx,
    qy        y component of the public key, as ASCII hex string
    d         private key, as ASCII hex string, optional if importing public
              key only
-   dp        Custom ecc_set_type
-   return    MP_OKAY on success
+   curve_id  The id of the curve.
+   @return    MP_OKAY on success
 */
 int wc_ecc_import_raw_ex(ecc_key* key, const char* qx, const char* qy,
                    const char* d, int curve_id)
 {
     return wc_ecc_import_raw_private(key, qx, qy, d, curve_id,
         WC_TYPE_HEX_STR);
-
 }
 
 /* Import x, y and optional private (d) as unsigned binary */

wrapper/rust/include.am

@@ -17,8 +17,10 @@ EXTRA_DIST += wrapper/rust/wolfssl/build.rs
 EXTRA_DIST += wrapper/rust/wolfssl/src/lib.rs
 EXTRA_DIST += wrapper/rust/wolfssl/src/wolfcrypt.rs
 EXTRA_DIST += wrapper/rust/wolfssl/src/wolfcrypt/aes.rs
+EXTRA_DIST += wrapper/rust/wolfssl/src/wolfcrypt/ecc.rs
 EXTRA_DIST += wrapper/rust/wolfssl/src/wolfcrypt/random.rs
 EXTRA_DIST += wrapper/rust/wolfssl/src/wolfcrypt/rsa.rs
 EXTRA_DIST += wrapper/rust/wolfssl/tests/test_aes.rs
+EXTRA_DIST += wrapper/rust/wolfssl/tests/test_ecc.rs
 EXTRA_DIST += wrapper/rust/wolfssl/tests/test_random.rs
 EXTRA_DIST += wrapper/rust/wolfssl/tests/test_rsa.rs

wrapper/rust/wolfssl/src/wolfcrypt.rs

@@ -19,5 +19,6 @@
  */
 
 pub mod aes;
+pub mod ecc;
 pub mod random;
 pub mod rsa;