Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in kyber.h header prevents using wc_MlKemKey_Decapsulate alias #8041

Open
tobiasbrunner opened this issue Oct 4, 2024 · 1 comment
Open

Typo in kyber.h header prevents using wc_MlKemKey_Decapsulate alias #8041

tobiasbrunner opened this issue Oct 4, 2024 · 1 comment
Assignees
@anhu
Labels
bug

Comments

@tobiasbrunner
Copy link

wc_MlKemKey_Decapsulate is incorrectly mapped to wc_KyberKey_Encapsulate instead of wc_KyberKey_Decapsulate:

wolfssl/wolfssl/wolfcrypt/kyber.h

Line 259 in 2e539ef

#define wc_MlKemKey_Decapsulate wc_KyberKey_Encapsulate

@tobiasbrunner
Copy link
Author

Just another small fixup:

wolfssl/configure.ac

Line 1272 in 2e539ef

[AS_HELP_STRING([--enable-kyber],[Enable KYBER (requires --enable-experimental) (default: disabled)])],

Doesn't seem the experimental switch is required anymore.

@embhorn embhorn added the bug label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anhu anhu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobiasbrunner @anhu @embhorn