refactor to ImportPeerECCKey

[effbiae]

Description

refactor duplicate code to ImportPeerECCKey()

Testing

./configure --enable-all && make check && \
./configure --enable-curve25519 --disable-ecc && make check && \
./configure CFLAGS="-pedantic -Wno-overlength-strings -Wdeclaration-after-statement -DTEST_LIBWOLFSSL_SOURCES_INCLUSION_SEQUENCE" --enable-sniffer --enable-curve25519 --enable-curve448 --enable-enckeys CPPFLAGS=-DWOLFSSL_DH_EXTRA --enable-debug && make check

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[wolfSSL-Bot]

Can one of the admins verify this patch?

[dgarske]

Okay to test. Contributor agreement on file

[dgarske]

This breaks the following test:

trying server command line[681]: SuiteTest -v 2 -l ECDH-RSA-DES-CBC3-SHA -c ./certs/server-ecc-rsa.pem -k ./certs/ecc-key.pem -2 -p 0 
listening on port 40235
trying client command line[682]: SuiteTest -v 2 -l ECDH-RSA-DES-CBC3-SHA -2 -p 40235 
connecting to 127.0.0.1:40235
SSL_accept error -353, ECC Make Key failure
wolfSSL error: SSL_accept failed
wolfSSL_connect error -313, received alert fatal error
wolfSSL error: wolfSSL_connect failed

[effbiae]

This breaks the following test:

trying server command line[681]: SuiteTest -v 2 -l ECDH-RSA-DES-CBC3-SHA -c ./certs/server-ecc-rsa.pem -k ./certs/ecc-key.pem -2 -p 0 
listening on port 40235
trying client command line[682]: SuiteTest -v 2 -l ECDH-RSA-DES-CBC3-SHA -2 -p 40235 
connecting to 127.0.0.1:40235
SSL_accept error -353, ECC Make Key failure
wolfSSL error: SSL_accept failed
wolfSSL_connect error -313, received alert fatal error
wolfSSL error: wolfSSL_connect failed

i've fixed a bug that would probably trigger this failure but i'm not sure how to reproduce this test so not certain...

[dgarske]

Very nice refactor. Almost there.

[dgarske]

Looks very good now, but please double check some of the PK callback haveCb logic wasn't lost in ecdhe_psk_kea case. Thank you

[dgarske]

Jenkins retest this please