Pass the total amount calculated in the ViewModel to the API

The `taxes` array returned by the API includes raw taxes, not rounded, while the `total_tax` property is using rounded values, and this leads to some inconsistencies for calculating the amount when using them, so for now, we calculate the total amount using `total_tax` in the ViewModel.

Author: hichamboushaba

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/refunds/IssueRefundViewModel.kt

@@ -303,7 +303,8 @@ class IssueRefundViewModel @Inject constructor(
         refundSummaryState = refundSummaryState.copy(
             isFormEnabled = true,
             previouslyRefunded = formatCurrency(order.refundTotal),
-            refundAmount = formatCurrency(commonState.refundTotal)
+            refundAmount = commonState.refundTotal,
+            refundAmountFormatted = formatCurrency(commonState.refundTotal)
         )
 
         triggerEvent(ShowRefundSummary)
@@ -399,11 +400,12 @@ class IssueRefundViewModel @Inject constructor(
         selectedFees?.forEach { allItems.add(it.toDataModel()) }
 
         return refundStore.createItemsRefund(
-            selectedSite.get(),
-            order.id,
-            refundSummaryState.refundReason ?: "",
-            true,
-            gateway.supportsRefunds,
+            site = selectedSite.get(),
+            orderId = order.id,
+            amount = refundSummaryState.refundAmount,
+            reason = refundSummaryState.refundReason ?: "",
+            restockItems = true,
+            autoRefund = gateway.supportsRefunds,
             items = allItems
         )
     }
@@ -808,7 +810,8 @@ class IssueRefundViewModel @Inject constructor(
     data class RefundSummaryViewState(
         val isFormEnabled: Boolean? = null,
         val previouslyRefunded: String? = null,
-        val refundAmount: String? = null,
+        val refundAmount: BigDecimal? = null,
+        val refundAmountFormatted: String? = null,
         val refundMethod: String? = null,
         val refundReason: String? = null,
         val isMethodDescriptionVisible: Boolean? = null,

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/refunds/RefundSummaryFragment.kt

@@ -100,7 +100,7 @@ class RefundSummaryFragment : BaseFragment(R.layout.fragment_refund_summary), Ba
             new.isSubmitButtonEnabled.takeIfNotEqualTo(old?.isSubmitButtonEnabled) {
                 binding.refundSummaryBtnRefund.isEnabled = new.isSubmitButtonEnabled
             }
-            new.refundAmount?.takeIfNotEqualTo(old?.refundAmount) {
+            new.refundAmountFormatted?.takeIfNotEqualTo(old?.refundAmountFormatted) {
                 binding.refundSummaryRefundAmount.text = it
                 binding.toolbar.title = resources.getString(
                     R.string.order_refunds_title_with_amount, it

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/refunds/RefundRestClient.kt

@@ -9,8 +9,9 @@ import org.wordpress.android.fluxc.model.refunds.WCRefundModel.WCRefundFeeLine
 import org.wordpress.android.fluxc.model.refunds.WCRefundModel.WCRefundShippingLine
 import org.wordpress.android.fluxc.network.rest.wpcom.wc.WooNetwork
 import org.wordpress.android.fluxc.network.rest.wpcom.wc.WooPayload
-import org.wordpress.android.fluxc.utils.sumBy
+import org.wordpress.android.fluxc.utils.extensions.filterNotNull
 import org.wordpress.android.fluxc.utils.toWooPayload
+import java.math.BigDecimal
 import javax.inject.Inject
 
 class RefundRestClient @Inject constructor(private val wooNetwork: WooNetwork) {
@@ -33,18 +34,20 @@ class RefundRestClient @Inject constructor(private val wooNetwork: WooNetwork) {
     suspend fun createRefundByItems(
         site: SiteModel,
         orderId: Long,
+        amount: BigDecimal?,
         reason: String,
         automaticRefund: Boolean,
         items: List<RefundRequestItem>,
         restockItems: Boolean
     ): WooPayload<RefundResponse> {
         val body = mapOf(
                 "reason" to reason,
-                "amount" to items.sumBy { it.total }.toString(),
+                "amount" to amount?.toString(),
                 "api_refund" to automaticRefund.toString(),
                 "line_items" to items,
                 "restock_items" to restockItems
-        )
+        ).filterNotNull()
+
         return createRefund(site, orderId, body)
     }
 

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/store/WCRefundStore.kt

@@ -20,7 +20,8 @@ import javax.inject.Singleton
 class WCRefundStore @Inject constructor(
     private val restClient: RefundRestClient,
     private val coroutineEngine: CoroutineEngine,
-    private val refundsMapper: RefundMapper
+    private val refundsMapper: RefundMapper,
+    private val wooCommerceStore: WooCommerceStore
 ) {
     companion object {
         // Just get everything
@@ -54,19 +55,21 @@ class WCRefundStore @Inject constructor(
     suspend fun createItemsRefund(
         site: SiteModel,
         orderId: Long,
+        amount: BigDecimal?,
         reason: String = "",
         restockItems: Boolean = true,
         autoRefund: Boolean = false,
         items: List<RefundRequestItem>
     ): WooResult<WCRefundModel> {
         return coroutineEngine.withDefaultContext(AppLog.T.API, this, "createItemsRefund") {
             val response = restClient.createRefundByItems(
-                    site,
-                    orderId,
-                    reason,
-                    autoRefund,
-                    items,
-                    restockItems
+                site = site,
+                orderId = orderId,
+                amount = amount,
+                reason = reason,
+                automaticRefund = autoRefund,
+                items = items,
+                restockItems = restockItems
             )
             return@withDefaultContext when {
                 response.isError -> WooResult(response.error)