Merge pull request #18189 from wordpress-mobile/feature/remove-land-in-the-editor-experiment

Use feature flag instead of ExPlat for land in the editor

Author: antonis

WordPress/Classes/Utility/AB Testing/ABTest.swift

@@ -2,7 +2,6 @@ import AutomatticTracks
 
 enum ABTest: String, CaseIterable {
     case unknown = "unknown"
-    case landInTheEditorPhase1 = "wpios_land_in_the_editor_phase1_v3"
 
     /// Returns a variation for the given experiment
     var variation: Variation {

WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift

@@ -23,6 +23,7 @@ enum FeatureFlag: Int, CaseIterable, OverrideableFlag {
     case notificationCommentDetails
     case statsPerformanceImprovements
     case siteIntentQuestion
+    case landInTheEditor
 
     /// Returns a boolean indicating if the feature is enabled
     var enabled: Bool {
@@ -74,6 +75,8 @@ enum FeatureFlag: Int, CaseIterable, OverrideableFlag {
             return true
         case .siteIntentQuestion:
             return false
+        case .landInTheEditor:
+            return false
         }
     }
 
@@ -142,6 +145,8 @@ extension FeatureFlag {
             return "Stats Performance Improvements"
         case .siteIntentQuestion:
             return "Site Intent Question"
+        case .landInTheEditor:
+            return "Land In The Editor"
         }
     }
 

WordPress/Classes/ViewRelated/Site Creation/FinalAssembly/LandInTheEditorHelper.swift

@@ -1,16 +1,16 @@
 typealias HomepageEditorCompletion = () -> Void
 
 class LandInTheEditorHelper {
-    /// Land in the editor, or continue as usual for the control group -  Used to branch on the ExPlat experiment for landing in the editor from the site creation flow
+    /// Land in the editor, or continue as usual -  Used to branch on the feature flag for landing in the editor from the site creation flow
     /// - Parameter blog: Blog (which was just created) for which to show the home page editor
     /// - Parameter navigationController: UINavigationController used to present the home page editor
-    /// - Parameter completion: HomepageEditorCompletion callback to be invoked after the user finishes editing the home page, or immediately in the control group case
+    /// - Parameter completion: HomepageEditorCompletion callback to be invoked after the user finishes editing the home page, or immediately iwhen the feature flag is disabled
     static func landInTheEditorOrContinue(for blog: Blog, navigationController: UINavigationController, completion: @escaping HomepageEditorCompletion) {
-        // branch here for explat variation
-        if ABTest.landInTheEditorPhase1.variation == .control {
-            completion()
-        } else {
+        // branch here for feature flag
+        if FeatureFlag.landInTheEditor.enabled {
             landInTheEditor(for: blog, navigationController: navigationController, completion: completion)
+        } else {
+            completion()
         }
     }