Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Select a coding standard #8

Open
markkap opened this issue Nov 6, 2018 · 2 comments
Open

Select a coding standard #8

markkap opened this issue Nov 6, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@markkap
Copy link

markkap commented Nov 6, 2018

Raising the issue because it is likely to have an impact on file structure.

Both the WordPress coding standard and the PSR require one class per file which is not how the code is structured right now. I would prefer going with the wordpress one, but it is not critical.

In a any case this probably means that the relevant files need to be in a directory

@mikeschinkel
Copy link
Member

@markkap Clearly I put them all classes in one file so that it could easily be included from the root, as one file. But with #4 that becomes much less of an issue.

Part of me likes the idea of the server only having to open one PHP file for all these classes, but a good server configuration will make that issue mostly moot so probably better to restructure into one class per file.

@mikeschinkel mikeschinkel self-assigned this Nov 6, 2018
@mikeschinkel mikeschinkel added the enhancement New feature or request label Nov 6, 2018
@mikeschinkel
Copy link
Member

@markkap See #12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants