Address CodeRabbit and Copilot review feedback on the Hurl Client PR

- Do not discard report entries whose line cannot be resolved once every
  cell boundary is claimed; attach them to the last boundary so an executed
  request never disappears from the notebook, and cover it with a test.
- Distinguish a comments-only cell from one holding content that parsed to
  no request. A malformed request previously ended its cell successfully,
  masking the error; it now fails with a "NOT PARSED" output.
- Drop the leftover deprecated onCommand activation event. Contributed
  commands are auto-activated from VS Code 1.74 and this extension targets
  ^1.100.0, so neither importHurlString entry is needed.
- Document that hurl.vars is resolved from hurl-client.fileRoot (defaulting
  to the notebook folder), and tag the variables-file example as ini.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: tharindulak

workspaces/api-tryit/hurl-runner/src/report-parser.ts

@@ -750,14 +750,20 @@ export function mapFileResultToCellOutcomes(fileResult: HurlFileResult, boundari
 	}
 
 	let cursor = 0;
-	for (const entry of unplaced) {
+	for (let i = 0; i < unplaced.length; i++) {
 		while (cursor < outcomes.length && outcomes[cursor].entries.length > 0) {
 			cursor++;
 		}
 		if (cursor >= outcomes.length) {
+			// Every boundary is already claimed. Rather than discard the
+			// remainder - which would hide requests that really executed -
+			// attach them to the last boundary so they still surface.
+			if (outcomes.length > 0) {
+				outcomes[outcomes.length - 1].entries.push(...unplaced.slice(i));
+			}
 			break;
 		}
-		outcomes[cursor].entries.push(entry);
+		outcomes[cursor].entries.push(unplaced[i]);
 		cursor++;
 	}
 

workspaces/api-tryit/hurl-runner/tests/report-parser.test.ts

@@ -587,6 +587,24 @@ describe('mapFileResultToCellOutcomes', () => {
 		expect(outcomes[1].entries.map(e => e.name)).toEqual(['Lineless entry']);
 	});
 
+	it('never discards a lineless entry when every boundary is already claimed', () => {
+		// Both boundaries are taken by line-matched entries, so there is no
+		// free slot left - the extra entry must still surface somewhere
+		// rather than vanishing from the notebook entirely.
+		const fileResult = makeFileResult([1, 5]);
+		fileResult.entries.push({ name: 'Lineless entry', status: 'passed' });
+		const boundaries = [
+			{ startLine: 1, endLine: 3 },
+			{ startLine: 5, endLine: 7 }
+		];
+
+		const outcomes = mapFileResultToCellOutcomes(fileResult, boundaries);
+
+		const rendered = outcomes.flatMap(o => o.entries.map(e => e.name));
+		expect(rendered).toContain('Lineless entry');
+		expect(rendered).toHaveLength(3);
+	});
+
 	it('does not let a lineless entry displace a boundary a line-matched entry already claimed', () => {
 		const fileResult = makeFileResult([5]); // matches the second boundary
 		fileResult.entries.push({ name: 'Lineless entry', status: 'passed' });

workspaces/hurl-client/hurl-client-extension/README.md

@@ -58,14 +58,14 @@ Select both cells above and run them together — `{{token}}` only resolves beca
 
 ## Variables
 
-To set your own variables (like a base URL or API key), create a file named `hurl.vars` in the same folder as your `.hurl` files:
+To set your own variables (like a base URL or API key), create a file named `hurl.vars`:
 
-```
+```ini
 base_url=https://api.example.com
 api_key=your-api-key
 ```
 
-Hurl Client picks this up automatically — no extra setup needed. Reference the values as `{{base_url}}`, `{{api_key}}`, etc. in your requests.
+Hurl Client looks for it in the folder set by `hurl-client.fileRoot`, which defaults to the notebook's own folder — so if you haven't changed that setting, put `hurl.vars` next to your `.hurl` files and it is picked up automatically. Reference the values as `{{base_url}}`, `{{api_key}}`, etc. in your requests.
 
 Need a different value for just one file? Add `<filename>.hurl.vars` (e.g. `requests.hurl.vars` for `requests.hurl`) — it overrides the shared file for the values it defines.
 

workspaces/hurl-client/hurl-client-extension/package.json

@@ -21,8 +21,7 @@
     "Notebooks"
   ],
   "activationEvents": [
-    "onNotebook:HurlClient",
-    "onCommand:HTTPClient.importHurlString"
+    "onNotebook:HurlClient"
   ],
   "icon": "images/icon.png",
   "main": "./dist/extension.js",

workspaces/hurl-client/hurl-client-extension/src/notebook/HurlNotebookController.ts

@@ -180,12 +180,13 @@ export class HurlNotebookController {
                 const entries = outcomes[index].entries;
 
                 if (entries.length === 0) {
-                    const hasRequest = cellHasRequest(content);
+                    const kind = classifyCellWithoutResult(content);
                     const laterEntryExists = outcomes.slice(index + 1).some(o => o.entries.length > 0);
-                    await execution.appendOutput([this.buildSkippedOutput(fileResult, hasRequest, laterEntryExists)]);
-                    // Nothing ran for this cell, so report no elapsed time
-                    // rather than the whole batch's.
-                    execution.end(!hasRequest, startedAt);
+                    await execution.appendOutput([this.buildSkippedOutput(fileResult, kind, laterEntryExists)]);
+                    // Only a comments-only cell is a success - a cell that
+                    // holds a request, or content hurl could not parse, failed.
+                    // Report no elapsed time either way, since nothing ran.
+                    execution.end(kind === 'comments', startedAt);
                     endedCount = index + 1;
                     continue;
                 }
@@ -340,14 +341,27 @@ export class HurlNotebookController {
         return isLastEntry ? extractResponseBody(fileResult.stdout) : undefined;
     }
 
-    private buildSkippedOutput(fileResult: HurlFileResult, hasRequest: boolean, laterEntryExists: boolean): vscode.NotebookCellOutput {
-        if (!hasRequest) {
+    private buildSkippedOutput(
+        fileResult: HurlFileResult,
+        kind: CellWithoutResultKind,
+        laterEntryExists: boolean
+    ): vscode.NotebookCellOutput {
+        if (kind === 'comments') {
             const md = '##### ℹ️ NO REQUEST\n\nThis cell has no request to run.';
             return new vscode.NotebookCellOutput([
                 vscode.NotebookCellOutputItem.text(md, 'text/markdown')
             ]);
         }
 
+        if (kind === 'unparsed') {
+            const detail = fileResult.errorMessage || fileResult.stderr;
+            const detailBlock = detail ? `\n\n\`\`\`\n${detail}\n\`\`\`` : '';
+            const md = `##### ❌ NOT PARSED\n\nNo runnable request was found in this cell. If it is meant to be a request, check its syntax - a malformed request also stops the rest of the run.${detailBlock}`;
+            return new vscode.NotebookCellOutput([
+                vscode.NotebookCellOutputItem.text(md, 'text/markdown')
+            ]);
+        }
+
         if (laterEntryExists) {
             // A later cell in the same run did produce an entry, so the run
             // didn't stop - hurl reached this request and skipped or failed
@@ -501,9 +515,28 @@ async function pathExists(filePath: string): Promise<boolean> {
     }
 }
 
-/** Does this cell's own text contain an actual hurl request, or is it just comments/notes? */
-function cellHasRequest(content: string): boolean {
-    return parseHurlDocument(content).blocks.length > 0;
+/**
+ * Why a cell produced no result:
+ *  - `request`      it does contain a request, so hurl either never reached it
+ *                   or refused to run it
+ *  - `comments`     nothing but comments/blank lines - genuinely nothing to run
+ *  - `unparsed`     it has real content that the parser found no request in,
+ *                   i.e. it is most likely malformed
+ *
+ * `comments` and `unparsed` must stay distinct: reporting a malformed request
+ * as "nothing to run" would end the cell successfully and hide the error.
+ */
+type CellWithoutResultKind = 'request' | 'comments' | 'unparsed';
+
+function classifyCellWithoutResult(content: string): CellWithoutResultKind {
+    if (parseHurlDocument(content).blocks.length > 0) {
+        return 'request';
+    }
+    const meaningfulLines = content
+        .split('\n')
+        .map(line => line.trim())
+        .filter(line => line.length > 0 && !line.startsWith('#'));
+    return meaningfulLines.length === 0 ? 'comments' : 'unparsed';
 }
 
 /**