make quiet more quiet

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/gui/WurstGuiCliImpl.java

@@ -1,6 +1,7 @@
 package de.peeeq.wurstscript.gui;
 
 import de.peeeq.wurstscript.attributes.CompileError;
+import de.peeeq.wurstscript.attributes.CompileError.ErrorType;
 
 /**
  * implementation for use with cli interfaces
@@ -19,9 +20,27 @@ public WurstGuiCliImpl(boolean compactOutput) {
 
     @Override
     public void sendError(CompileError err) {
+        if (compactOutput && isGeneratedJassNameResolutionWarning(err)) {
+            return;
+        }
         super.sendError(err);
     }
 
+    private boolean isGeneratedJassNameResolutionWarning(CompileError err) {
+        if (err.getErrorType() != ErrorType.WARNING) {
+            return false;
+        }
+        String message = err.getMessage();
+        if (!message.contains("Could not find variable") && !message.contains("Could not find a function")) {
+            return false;
+        }
+        String source = err.getSource().getFile().replace('\\', '/').toLowerCase();
+        return source.endsWith("war3map.j")
+            || source.endsWith("output.j")
+            || source.contains("/_build/")
+            || source.startsWith("_build/");
+    }
+
     @Override
     public void sendProgress(String msg) {
     }

de.peeeq.wurstscript/src/test/java/tests/wurstscript/utils/UtilsTest.java

@@ -5,6 +5,8 @@
 import de.peeeq.wurstscript.utils.Utils;
 import de.peeeq.wurstscript.RunArgs;
 import de.peeeq.wurstscript.attributes.CompileError;
+import de.peeeq.wurstscript.attributes.CompileError.ErrorType;
+import de.peeeq.wurstscript.gui.WurstGuiCliImpl;
 import de.peeeq.wurstscript.parser.WPos;
 import org.testng.Assert;
 import org.testng.annotations.Test;
@@ -33,6 +35,22 @@ public void compactCompileErrorIsSingleLine() {
         Assert.assertTrue(error.toCompactString().contains("first line second line"));
     }
 
+    @Test
+    public void compactCliSuppressesGeneratedJassNameResolutionWarnings() {
+        CompileError generatedWarning = new CompileError(
+                new WPos("C:/project/_build/grill/war3map.j", null, 0, 0),
+                "Error:  e:Could not find variable silverGladeCounter.",
+                ErrorType.WARNING);
+
+        WurstGuiCliImpl compactGui = new WurstGuiCliImpl(true);
+        compactGui.sendError(generatedWarning);
+        Assert.assertTrue(compactGui.getWarningList().isEmpty());
+
+        WurstGuiCliImpl regularGui = new WurstGuiCliImpl(false);
+        regularGui.sendError(generatedWarning);
+        Assert.assertEquals(regularGui.getWarningList().size(), 1);
+    }
+
     @Test
     public void array() {
         int[] ar1 = {1, 2, 3};