Commit 8bcdfde
committed
Fix cache manifest not saving: open MPQ writable in ProjectConfigBuilder
`ProjectConfigBuilder.apply()` opens the target map MPQ to save the
updated cache manifest, but passes `readOnly=true` to `getEditor()`.
The subsequent `saveManifest()` call tries to insert a file via
`mpq.insertFile()`, which calls `JMpqEditor.deleteFile()` internally.
JMPQ3 throws `NonWritableChannelException` (with a null message)
when the editor is read-only, resulting in:
Warning: Could not save manifest to MPQ: null
This silently breaks the build caching system introduced in #1096 —
every build becomes a full rebuild because the manifest is never
persisted.
Fix: change `readOnly` from `true` to `false` so the manifest can
actually be written.1 parent 6b6494f commit 8bcdfde
File tree
1 file changed
+2
-2
lines changed- de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
| 100 | + | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
0 commit comments