chore: default machine CPU to Cores/2 (podman-desktop#6755)

Author: vzhukovs

extensions/podman/package.json

@@ -55,7 +55,7 @@
           "type": "number",
           "format": "cpu",
           "minimum": 1,
-          "default": 2,
+          "default": "HOST_HALF_CPU_CORES",
           "maximum": "HOST_TOTAL_CPU",
           "scope": "ContainerConnection",
           "description": "CPU(s)"
@@ -109,7 +109,7 @@
         "podman.factory.machine.cpus": {
           "type": "number",
           "format": "cpu",
-          "default": 2,
+          "default": "HOST_HALF_CPU_CORES",
           "minimum": 1,
           "maximum": "HOST_TOTAL_CPU",
           "scope": "ContainerProviderConnectionFactory",

packages/renderer/src/lib/preferences/PreferencesConnectionCreationOrEditRendering.svelte

@@ -37,7 +37,7 @@ import {
   startTask,
 } from './preferences-connection-rendering-task';
 import PreferencesRenderingItemFormat from './PreferencesRenderingItemFormat.svelte';
-import { getInitialValue, isPropertyValidInContext, writeToTerminal } from './Util';
+import { calcHalfCpuCores, getInitialValue, isPropertyValidInContext, writeToTerminal } from './Util';
 
 export let properties: IConfigurationPropertyRecordedSchema[] = [];
 export let providerInfo: ProviderInfo;
@@ -134,6 +134,17 @@ onMount(async () => {
     .filter(property => property.id?.startsWith(providerInfo.id))
     .filter(property => isPropertyValidInContext(property.when, globalContext))
     .map(property => {
+      switch (property.default) {
+        case 'HOST_HALF_CPU_CORES': {
+          if (osCpu) {
+            property.default = calcHalfCpuCores(osCpu);
+          }
+          break;
+        }
+        default: {
+          break;
+        }
+      }
       switch (property.maximum) {
         case 'HOST_TOTAL_DISKSIZE': {
           if (osFreeDisk) {

packages/renderer/src/lib/preferences/Util.spec.ts

@@ -21,6 +21,7 @@ import { afterEach, describe, expect, test, vi } from 'vitest';
 import type { IConfigurationPropertyRecordedSchema } from '../../../../main/src/plugin/configuration-registry';
 import { ContextUI } from '../context/context';
 import {
+  calcHalfCpuCores,
   getNormalizedDefaultNumberValue,
   isPropertyValidInContext,
   isTargetScope,
@@ -231,3 +232,26 @@ describe.each([
     expect(validateProxyAddress(address)).toBeDefined();
   });
 });
+
+describe('calcHalfCpuCores', () => {
+  test('should return half of the provided CPU cores as a number', () => {
+    expect(calcHalfCpuCores('4')).toBe(2);
+    expect(calcHalfCpuCores('10')).toBe(5);
+  });
+
+  test('should return 1 if provided CPU cores are 0', () => {
+    expect(calcHalfCpuCores('0')).toBe(1);
+  });
+
+  test('should handle same integer value if CPU has one core', () => {
+    expect(calcHalfCpuCores('1')).toBe(1);
+  });
+
+  test('should return 1 for non-numeric strings', () => {
+    expect(calcHalfCpuCores('not-a-number')).toBe(1);
+  });
+
+  test('should return 1 for negative numbers', () => {
+    expect(calcHalfCpuCores('-4')).toBe(1);
+  });
+});

packages/renderer/src/lib/preferences/Util.ts

@@ -168,3 +168,13 @@ export function isContainerConnection(
 ): connection is ProviderContainerConnectionInfo {
   return (connection as ProviderContainerConnectionInfo).endpoint.socketPath !== undefined;
 }
+
+export function calcHalfCpuCores(osCpu: string): number {
+  const cores = parseInt(osCpu, 10);
+  if (isNaN(cores) || cores <= 0) {
+    return 1;
+  }
+
+  const hCores = Math.floor(cores / 2);
+  return hCores === 0 ? 1 : hCores;
+}