chore(tests): number refactoring

Signed-off-by: xbabalov <[email protected]>

Author: xbabalov

tests/playwright/src/model/pages/create-machine-page.ts

@@ -83,14 +83,14 @@ export class CreateMachinePage extends BasePage {
     }
 
     await this.createMachineButton.click();
-    await this.page.waitForTimeout(60000);
+    await this.page.waitForTimeout(60_000);
 
     const successfulCreationMessage = this.page.getByText('Successful operation');
     const goBackToResourcesButton = this.page.getByRole('button', { name: 'Go back to resources' });
 
     await this.handleConnectionDialog(machineName, setAsDefault);
 
-    await playExpect(successfulCreationMessage).toBeVisible({ timeout: 10000 });
+    await playExpect(successfulCreationMessage).toBeVisible({ timeout: 10_000 });
     await playExpect(goBackToResourcesButton).toBeVisible();
     await goBackToResourcesButton.click();
 

tests/playwright/src/specs/podman-machine-rootless.spec.ts

@@ -69,5 +69,5 @@ describe.skipIf(os.platform() === 'linux')('Rootless Podman machine Verification
     const machineBox = new ResourceConnectionCardPage(page, 'podman', MACHINE_VISIBLE_NAME);
     const connectionStatusLabel = await machineBox.resourceElementConnectionStatus.textContent();
     playExpect(connectionStatusLabel === 'RUNNING').toBeTruthy();
-  }, 150000);
+  }, 150_000);
 });

tests/playwright/src/utility/operations.ts

@@ -55,7 +55,7 @@ export async function deleteContainer(page: Page, name: string): Promise<void> {
     // wait for container to disappear
     try {
       console.log('Waiting for container to get deleted ...');
-      await playExpect.poll(async () => await containers.getContainerRowByName(name), { timeout: 10000 }).toBeFalsy();
+      await playExpect.poll(async () => await containers.getContainerRowByName(name), { timeout: 10_000 }).toBeFalsy();
     } catch (error) {
       if (!(error as Error).message.includes('Page is empty')) {
         throw Error(`Error waiting for container '${name}' to get removed, ${error}`);
@@ -77,7 +77,7 @@ export async function deleteImage(page: Page, name: string): Promise<void> {
     console.log(`image '${name}' does not exist, skipping...`);
   } else {
     const deleteButton = row.getByRole('button', { name: 'Delete Image' });
-    if (await deleteButton.isEnabled({ timeout: 2000 })) {
+    if (await deleteButton.isEnabled({ timeout: 2_000 })) {
       await deleteButton.click();
       await handleConfirmationDialog(page);
     } else {
@@ -92,7 +92,7 @@ export async function deleteImage(page: Page, name: string): Promise<void> {
           const result = await images.getImageRowByName(name);
           return !!result;
         },
-        { timeout: 10000, sendError: false },
+        { timeout: 10_000, sendError: false },
       );
     } catch (error) {
       if (!(error as Error).message.includes('Page is empty')) {
@@ -138,7 +138,7 @@ export async function deletePod(page: Page, name: string): Promise<void> {
         async () => {
           return !!(await pods.getPodRowByName(name));
         },
-        { timeout: 20000 },
+        { timeout: 20_000 },
       );
     } catch (error) {
       if (!(error as Error).message.includes('Page is empty')) {
@@ -158,7 +158,7 @@ export async function handleConfirmationDialog(
 ): Promise<void> {
   // wait for dialog to appear using waitFor
   const dialog = page.getByRole('dialog', { name: dialogTitle, exact: true });
-  await dialog.waitFor({ state: 'visible', timeout: 3000 });
+  await dialog.waitFor({ state: 'visible', timeout: 3_000 });
   const button = confirm
     ? dialog.getByRole('button', { name: confirmationButton })
     : dialog.getByRole('button', { name: cancelButton });
@@ -174,23 +174,23 @@ export async function deletePodmanMachine(page: Page, machineVisibleName: string
   const RESOURCE_NAME: string = 'podman';
   const navigationBar = new NavigationBar(page);
   const dashboardPage = await navigationBar.openDashboard();
-  await playExpect(dashboardPage.mainPage).toBeVisible({ timeout: 3000 });
+  await playExpect(dashboardPage.mainPage).toBeVisible({ timeout: 3_000 });
   const settingsBar = await navigationBar.openSettings();
   const resourcesPage = await settingsBar.openTabPage(ResourcesPage);
   await playExpect
-    .poll(async () => await resourcesPage.resourceCardIsVisible(RESOURCE_NAME), { timeout: 10000 })
+    .poll(async () => await resourcesPage.resourceCardIsVisible(RESOURCE_NAME), { timeout: 10_000 })
     .toBeTruthy();
   const podmanResourceCard = new ResourceConnectionCardPage(page, RESOURCE_NAME, machineVisibleName);
   await playExpect(podmanResourceCard.providerConnections).toBeVisible({ timeout: 10_000 });
   await waitUntil(
     async function machineExists() {
       return await podmanResourceCard.resourceElement.isVisible();
     },
-    { timeout: 15000, sendError: false },
+    { timeout: 15_000, sendError: false },
   );
   if (await podmanResourceCard.resourceElement.isVisible()) {
-    await playExpect(podmanResourceCard.resourceElementConnectionActions).toBeVisible({ timeout: 3000 });
-    await playExpect(podmanResourceCard.resourceElementConnectionStatus).toBeVisible({ timeout: 3000 });
+    await playExpect(podmanResourceCard.resourceElementConnectionActions).toBeVisible({ timeout: 3_000 });
+    await playExpect(podmanResourceCard.resourceElementConnectionStatus).toBeVisible({ timeout: 3_000 });
     if ((await podmanResourceCard.resourceElementConnectionStatus.innerText()) === ResourceElementState.Starting) {
       console.log('Podman machine is in starting currently, will send stop command via CLI');
       execSync(`podman machine stop ${machineVisibleName}`);
@@ -202,12 +202,12 @@ export async function deletePodmanMachine(page: Page, machineVisibleName: string
     if ((await podmanResourceCard.resourceElementConnectionStatus.innerText()) === ResourceElementState.Running) {
       await podmanResourceCard.performConnectionAction(ResourceElementActions.Stop);
       await playExpect(podmanResourceCard.resourceElementConnectionStatus).toHaveText(ResourceElementState.Off, {
-        timeout: 300_000,
+        timeout: 150_000,
       });
     }
     await podmanResourceCard.performConnectionAction(ResourceElementActions.Delete);
     await playExpect(podmanResourceCard.resourceElement).toBeHidden({ timeout: 30_000 });
-    await page.waitForTimeout(30000);
+    await page.waitForTimeout(30_000);
     await handleResetDefaultConnectionDialog(page);
   } else {
     console.log(`Podman machine [${machineVisibleName}] not present, skipping deletion.`);