Skip to content

Commit 4365ad9

Browse files
authored
fix(ci): run and build right e2e tests artifacts on e2e-test-main (podman-desktop#8809)
* fix(ci): run and build right e2e tests artifacts on e2e-test-main Signed-off-by: Ondrej Dockal <[email protected]> * chore(test): add @Update-Install tag and adjust test:e2e:run target Signed-off-by: Ondrej Dockal <[email protected]>
1 parent 0ad301c commit 4365ad9

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

.github/workflows/e2e-main.yaml

+4-7
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,10 @@ jobs:
102102
103103
win-update-e2e-test:
104104
name: win update e2e tests
105-
runs-on: ${{ matrix.os }}
106-
timeout-minutes: 40
107-
strategy:
108-
fail-fast: false
109-
matrix:
110-
os: [windows-2022]
105+
runs-on: windows-2022
106+
env:
107+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
108+
timeout-minutes: 60
111109
steps:
112110
- uses: actions/checkout@v4
113111
with:
@@ -135,7 +133,6 @@ jobs:
135133
run: pnpm install --frozen-lockfile
136134

137135
- name: Adjust/Downgrade local podman desktop version Windows
138-
if: ${{ matrix.os=='windows-2022'}}
139136
run: |
140137
$version="1.0.0"
141138
jq --arg version "$version" '.version = $version' package.json | Out-File -FilePath package.json_tmp

package.json

+2-3
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,15 @@
3838
"test:unit": "npm run test:main && npm run test:preload && npm run test:preload-docker-extension && npm run test:preload-webview && npm run test:ui && npm run test:renderer && npm run test:scripts:stylesheet && npm run test:tools && npm run test:extensions",
3939
"test:e2e": "npm run test:e2e:build && npm run test:e2e:run",
4040
"test:e2e:build": "cross-env NODE_ENV=development MODE=development DEBUG=pw:browser npm run build",
41-
"test:e2e:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/",
41+
"test:e2e:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/ --grep-invert @update-install",
4242
"test:e2e:smoke": "npm run test:e2e:build && npm run test:e2e:smoke:run",
4343
"test:e2e:smoke:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/ -g @smoke",
4444
"test:e2e:extension": "npm run test:e2e:build && npm run test:e2e:extension:run",
4545
"test:e2e:extension:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/extension-installation.spec.ts",
4646
"test:e2e:pw": "npm run test:e2e:build && npm run test:e2e:pw:run",
4747
"test:e2e:pw:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/pod-smoke.spec.ts",
4848
"test:e2e:update": "npm run test:e2e:build && npm run test:e2e:update:run",
49-
"test:e2e:update:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/installation/update-install.spec.ts",
50-
"test:e2e:copy": "cp ../podman-desktop-extension-bootc/tests/src/bootc-extension.spec.ts tests/src/",
49+
"test:e2e:update:run": "xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' -- npx playwright test tests/playwright/src/specs/installation/ -g @update-install",
5150
"test:main": "vitest run -r packages/main --passWithNoTests --coverage",
5251
"test:preload": "vitest run -r packages/preload --passWithNoTests --coverage",
5352
"test:preload-docker-extension": "vitest run -r packages/preload-docker-extension --passWithNoTests --coverage",

tests/playwright/src/specs/installation/update-install.spec.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,16 @@ import type { Locator } from '@playwright/test';
2121
import type { StatusBar } from '../../model/workbench/status-bar';
2222
import { expect as playExpect, test } from '../../utility/fixtures';
2323
import { handleConfirmationDialog } from '../../utility/operations';
24+
import { isLinux } from '../../utility/platform';
2425

2526
let sBar: StatusBar;
2627
let updateAvailableDialog: Locator;
2728
let updateDialog: Locator;
2829
let updateDownloadedDialog: Locator;
2930
const performUpdate = process.env.UPDATE_PODMAN_DESKTOP ? process.env.UPDATE_PODMAN_DESKTOP : false;
3031

32+
test.skip(isLinux, 'Update is not supported on Linux');
33+
3134
test.beforeAll(async ({ runner, page, statusBar }) => {
3235
runner.setVideoAndTraceName('update-e2e');
3336

@@ -41,7 +44,7 @@ test.afterAll(async ({ runner }) => {
4144
await runner.close();
4245
});
4346

44-
test.describe.serial('Podman Desktop Update Update installation offering', () => {
47+
test.describe.serial('Podman Desktop Update Update installation offering @update-install', () => {
4548
test('Update is offered automatically on startup', async ({ welcomePage }) => {
4649
await playExpect(updateAvailableDialog).toBeVisible();
4750
const updateNowButton = updateAvailableDialog.getByRole('button', { name: 'Update Now' });

0 commit comments

Comments
 (0)