chore: fix @typescript-eslint/no-unused-vars rule

allow the usage of _ prefix to ignore the pattern

Signed-off-by: Florent Benoit <[email protected]>

Author: benoitf

.eslintrc.json

@@ -59,7 +59,7 @@
     "**/dist/**"
   ],
   "rules": {
-    "@typescript-eslint/no-unused-vars": "error",
+    "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
     "@typescript-eslint/no-var-requires": "off",
     "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/no-explicit-any": "error",

packages/renderer/.eslintrc.json

@@ -13,7 +13,6 @@
     "@typescript-eslint/no-empty-function": "off",
     "no-undef": "off",
     "sonarjs/no-collapsible-if": "off",
-    "@typescript-eslint/no-unused-vars": "off",
     "@typescript-eslint/prefer-optional-chain": "off",
     "svelte/no-at-html-tags": "off",
     "no-useless-escape": "off",

packages/renderer/src/App.svelte

@@ -8,16 +8,13 @@ import { router } from 'tinro';
 
 import Route from './Route.svelte';
 import ContainerList from './lib/ContainerList.svelte';
-import { onMount } from 'svelte';
 import ImagesList from './lib/ImagesList.svelte';
 import ProviderList from './lib/ProviderList.svelte';
 import PreferencesPage from './lib/preferences/PreferencesPage.svelte';
 import BuildImageFromContainerfile from './lib/image/BuildImageFromContainerfile.svelte';
 import PullImage from './lib/image/PullImage.svelte';
 import DockerExtension from './lib/docker-extension/DockerExtension.svelte';
 import ContainerDetails from './lib/container/ContainerDetails.svelte';
-import { providerInfos } from './stores/providers';
-import type { ProviderInfo } from '../../main/src/plugin/api/provider-info';
 import WelcomePage from './lib/welcome/WelcomePage.svelte';
 import DashboardPage from './lib/dashboard/DashboardPage.svelte';
 import HelpPage from './lib/help/HelpPage.svelte';
@@ -50,18 +47,6 @@ router.subscribe(function (navigation) {
   }
 });
 
-let providers: ProviderInfo[] = [];
-$: providerConnections = providers
-  .map(provider => provider.containerConnections)
-  .flat()
-  .filter(providerContainerConnection => providerContainerConnection.status === 'started');
-
-onMount(() => {
-  providerInfos.subscribe(value => {
-    providers = value;
-  });
-});
-
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 window.events?.receive('display-help', () => {

packages/renderer/src/PreferencesNavigation.svelte

@@ -6,9 +6,8 @@ import { CONFIGURATION_DEFAULT_SCOPE } from '../../main/src/plugin/configuration
 
 export let meta;
 
-let extensions, configProperties: Map<string, { id: string; title: string }>;
+let configProperties: Map<string, { id: string; title: string }>;
 
-$: extensions = [];
 $: configProperties = new Map();
 $: sectionExpanded = {};
 
@@ -17,9 +16,6 @@ function toggleSection(provider: string) {
 }
 
 onMount(async () => {
-  extensionInfos.subscribe(value => {
-    extensions = value;
-  });
   configurationProperties.subscribe(value => {
     configProperties = value
       .filter(property => property.scope === CONFIGURATION_DEFAULT_SCOPE)

packages/renderer/src/lib/ContainerList.svelte

@@ -279,10 +279,6 @@ function toggleCreateContainer(): void {
   openChoiceModal = !openChoiceModal;
 }
 
-function runContainerYaml(): void {
-  router.goto('/containers/play');
-}
-
 function fromDockerfile(): void {
   openChoiceModal = false;
   router.goto('/images/build');

packages/renderer/src/lib/container/ContainerActions.svelte

@@ -23,51 +23,51 @@ export let detailed = false;
 export let inProgressCallback: (inProgress: boolean, state?: string) => void = () => {};
 export let errorCallback: (erroMessage: string) => void = () => {};
 
-async function startContainer(containerInfo: ContainerInfoUI) {
+async function startContainer() {
   inProgressCallback(true, 'STARTING');
   try {
-    await window.startContainer(containerInfo.engineId, containerInfo.id);
+    await window.startContainer(container.engineId, container.id);
   } catch (error) {
     errorCallback(error);
   } finally {
     inProgressCallback(false, 'RUNNING');
   }
 }
 
-async function restartContainer(containerInfo: ContainerInfoUI) {
+async function restartContainer() {
   inProgressCallback(true, 'RESTARTING');
   try {
-    await window.restartContainer(containerInfo.engineId, containerInfo.id);
+    await window.restartContainer(container.engineId, container.id);
   } catch (error) {
     errorCallback(error);
   } finally {
     inProgressCallback(false);
   }
 }
 
-async function stopContainer(containerInfo: ContainerInfoUI) {
+async function stopContainer() {
   inProgressCallback(true, 'STOPPING');
   try {
-    await window.stopContainer(containerInfo.engineId, containerInfo.id);
+    await window.stopContainer(container.engineId, container.id);
   } catch (error) {
     errorCallback(error);
   } finally {
     inProgressCallback(false, 'STOPPED');
   }
 }
 
-function openBrowser(containerInfo: ContainerInfoUI): void {
-  window.openExternal(containerInfo.openingUrl);
+function openBrowser(): void {
+  window.openExternal(container.openingUrl);
 }
 
-function openLogs(containerInfo: ContainerInfoUI): void {
+function openLogs(): void {
   router.goto(`/containers/${container.id}/logs`);
 }
 
-async function deleteContainer(containerInfo: ContainerInfoUI): Promise<void> {
+async function deleteContainer(): Promise<void> {
   inProgressCallback(true, 'DELETING');
   try {
-    await window.deleteContainer(containerInfo.engineId, containerInfo.id);
+    await window.deleteContainer(container.engineId, container.id);
     router.goto('/containers/');
   } catch (error) {
     errorCallback(error);
@@ -76,7 +76,7 @@ async function deleteContainer(containerInfo: ContainerInfoUI): Promise<void> {
   }
 }
 
-function openTerminalContainer(containerInfo: ContainerInfoUI): void {
+function openTerminalContainer(): void {
   router.goto(`/containers/${container.id}/terminal`);
 }
 
@@ -100,7 +100,7 @@ if (dropdownMenu) {
 
 <ListItemButtonIcon
   title="Start Container"
-  onClick="{() => startContainer(container)}"
+  onClick="{() => startContainer()}"
   hidden="{container.state === 'RUNNING' || container.state === 'STOPPING'}"
   detailed="{detailed}"
   inProgress="{container.actionInProgress && container.state === 'STARTING'}"
@@ -109,15 +109,15 @@ if (dropdownMenu) {
 
 <ListItemButtonIcon
   title="Stop Container"
-  onClick="{() => stopContainer(container)}"
+  onClick="{() => stopContainer()}"
   hidden="{!(container.state === 'RUNNING' || container.state === 'STOPPING')}"
   detailed="{detailed}"
   inProgress="{container.actionInProgress && container.state === 'STOPPING'}"
   icon="{faStop}" />
 
 <ListItemButtonIcon
   title="Delete Container"
-  onClick="{() => deleteContainer(container)}"
+  onClick="{() => deleteContainer()}"
   icon="{faTrash}"
   detailed="{detailed}"
   inProgress="{container.actionInProgress && container.state === 'DELETING'}" />
@@ -127,7 +127,7 @@ if (dropdownMenu) {
   {#if !detailed}
     <ListItemButtonIcon
       title="Open Logs"
-      onClick="{() => openLogs(container)}"
+      onClick="{() => openLogs()}"
       menu="{dropdownMenu}"
       detailed="{false}"
       icon="{faAlignLeft}" />
@@ -150,7 +150,7 @@ if (dropdownMenu) {
     icon="{faRocket}" />
   <ListItemButtonIcon
     title="Open Browser"
-    onClick="{() => openBrowser(container)}"
+    onClick="{() => openBrowser()}"
     menu="{dropdownMenu}"
     enabled="{container.state === 'RUNNING' && container.hasPublicPort}"
     hidden="{dropdownMenu && container.state !== 'RUNNING'}"
@@ -159,15 +159,15 @@ if (dropdownMenu) {
   {#if !detailed}
     <ListItemButtonIcon
       title="Open Terminal"
-      onClick="{() => openTerminalContainer(container)}"
+      onClick="{() => openTerminalContainer()}"
       menu="{dropdownMenu}"
       hidden="{!(container.state === 'RUNNING')}"
       detailed="{false}"
       icon="{faTerminal}" />
   {/if}
   <ListItemButtonIcon
     title="Restart Container"
-    onClick="{() => restartContainer(container)}"
+    onClick="{() => restartContainer()}"
     menu="{dropdownMenu}"
     detailed="{detailed}"
     icon="{faArrowsRotate}" />

packages/renderer/src/lib/container/ContainerDetailsLogs.svelte

@@ -104,7 +104,7 @@ onMount(async () => {
   await refreshTerminal();
   fetchContainerLogs();
   // Resize the terminal each time we change the div size
-  resizeObserver = new ResizeObserver(entries => {
+  resizeObserver = new ResizeObserver(() => {
     termFit?.fit();
   });
 

packages/renderer/src/lib/dashboard/ProviderConfiguring.svelte

@@ -29,16 +29,6 @@ let logsTerminal;
 let resizeObserver: ResizeObserver;
 let termFit: FitAddon;
 
-async function initializeProvider() {
-  initializeError = undefined;
-  logsTerminal.clear();
-  initializationContext.promise?.catch((error: unknown) => {
-    initializeError = String(error);
-    logsTerminal.write(error + '\r');
-    console.error('Error while initializing the provider', error);
-  });
-}
-
 async function refreshTerminal() {
   // missing element, return
   if (!logsXtermDiv) {
@@ -81,7 +71,7 @@ onMount(async () => {
   refreshTerminal();
 
   // Resize the terminal each time we change the div size
-  resizeObserver = new ResizeObserver(entries => {
+  resizeObserver = new ResizeObserver(() => {
     termFit?.fit();
   });
 

packages/renderer/src/lib/dashboard/ProviderInstalled.svelte

@@ -100,7 +100,7 @@ onMount(async () => {
   refreshTerminal();
 
   // Resize the terminal each time we change the div size
-  resizeObserver = new ResizeObserver(entries => {
+  resizeObserver = new ResizeObserver(() => {
     termFit?.fit();
   });
 

packages/renderer/src/lib/dashboard/ProviderStarting.svelte

@@ -1,5 +1,5 @@
 <script lang="ts">
-import type { CheckStatus, ProviderInfo } from '../../../../main/src/plugin/api/provider-info';
+import type { ProviderInfo } from '../../../../main/src/plugin/api/provider-info';
 import ProviderLinks from './ProviderLinks.svelte';
 import ProviderLogo from './ProviderLogo.svelte';
 

packages/renderer/src/lib/dashboard/ProviderWarnings.svelte

@@ -1,6 +1,5 @@
 <script lang="ts">
 import type { ProviderInfo } from '../../../../main/src/plugin/api/provider-info';
-import type * as extensionApi from '@podman-desktop/api';
 import { providerInfos } from '../../stores/providers';
 
 export let provider: ProviderInfo;

packages/renderer/src/lib/docker-extension/DockerExtension.svelte

@@ -38,7 +38,7 @@ window.events?.receive('dev-tools:open-extension', extensionId => {
 </script>
 
 {#if source && preloadPath}
-  <Route path="/*" breadcrumb="{name}" let:meta>
+  <Route path="/*" breadcrumb="{name}">
     <webview
       id="dd-webview-{webviewId}"
       src="{source}?extensionName={currentContrib.extensionId}&arch={arch}&hostname={hostname}&platform={platform}"

packages/renderer/src/lib/engine/Prune.svelte

@@ -1,6 +1,5 @@
 <script lang="ts">
 import type { EngineInfoUI } from './EngineInfoUI';
-import type { MessageBoxReturnValue } from '../../../../main/src/plugin/message-box';
 
 // Imported type for prune (containers, images, pods, volumes)
 export let type: string;

packages/renderer/src/lib/featured/FeaturedExtensionDownload.svelte

@@ -1,7 +1,6 @@
 <script lang="ts">
 import type { FeaturedExtension } from '../../../../main/src/plugin/featured/featured-api';
-import { faCheckCircle, faDownload } from '@fortawesome/free-solid-svg-icons';
-import Fa from 'svelte-fa/src/fa.svelte';
+import { faDownload } from '@fortawesome/free-solid-svg-icons';
 import LoadingIcon from '../ui/LoadingIcon.svelte';
 import ErrorMessage from '../ui/ErrorMessage.svelte';
 

packages/renderer/src/lib/featured/FeaturedExtensions.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
 import { featuredExtensionInfos } from '/@/stores/featuredExtensions';
-import { faCheckCircle, faCircleXmark, faDownload } from '@fortawesome/free-solid-svg-icons';
+import { faCheckCircle, faCircleXmark } from '@fortawesome/free-solid-svg-icons';
 import Fa from 'svelte-fa/src/fa.svelte';
 import FeaturedExtensionDownload from './FeaturedExtensionDownload.svelte';
 </script>

packages/renderer/src/lib/image/PushImageModal.svelte

@@ -10,12 +10,6 @@ import type { ImageInfoUI } from './ImageInfoUI';
 export let closeCallback: () => void;
 export let imageInfoToPush: ImageInfoUI;
 
-function keydownDockerfileChoice(e: KeyboardEvent) {
-  e.stopPropagation();
-  if (e.key === 'Escape') {
-    closeCallback();
-  }
-}
 let pushInProgress = false;
 let pushFinished = false;
 let logsPush;

packages/renderer/src/lib/images/StatusIcon.svelte

@@ -1,6 +1,5 @@
 <script lang="ts">
 import StarIcon from './StarIcon.svelte';
-import { SvelteComponent } from 'svelte';
 
 // status: one of RUNNING, STARTING, USED, CREATED, or DEGRADED
 // any other status will result in a standard outlined box

packages/renderer/src/lib/kube/KubePlayYAML.svelte

@@ -1,5 +1,5 @@
 <script lang="ts">
-import { onMount, tick, onDestroy } from 'svelte';
+import { onMount, onDestroy } from 'svelte';
 import type { Unsubscriber } from 'svelte/store';
 import type { ProviderContainerConnectionInfo, ProviderInfo } from '../../../../main/src/plugin/api/provider-info';
 let providerUnsubscribe: Unsubscriber;

packages/renderer/src/lib/pod/PodDetailsLogs.svelte

@@ -164,7 +164,7 @@ onMount(async () => {
   fetchPodLogs();
 
   // Resize the terminal each time we change the div size
-  resizeObserver = new ResizeObserver(entries => {
+  resizeObserver = new ResizeObserver(() => {
     termFit?.fit();
   });
 

packages/renderer/src/lib/pod/PodsList.svelte

@@ -17,8 +17,6 @@ import PodActions from './PodActions.svelte';
 import KubePlayButton from '../kube/KubePlayButton.svelte';
 import moment from 'moment';
 import Tooltip from '../ui/Tooltip.svelte';
-import Fa from 'svelte-fa/src/fa.svelte';
-import { faExclamationCircle } from '@fortawesome/free-solid-svg-icons';
 import Prune from '../engine/Prune.svelte';
 import type { EngineInfoUI } from '../engine/EngineInfoUI';
 import ErrorMessage from '../ui/ErrorMessage.svelte';

packages/renderer/src/lib/preferences/PreferencesConnectionCreationRendering.svelte

@@ -133,7 +133,7 @@ onDestroy(() => {
   }
 });
 
-function handleInvalidComponent(_error: string) {
+function handleInvalidComponent() {
   isValid = false;
 }
 

packages/renderer/src/lib/preferences/PreferencesContainerConnectionRendering.svelte

@@ -4,7 +4,7 @@ import type { IConfigurationPropertyRecordedSchema } from '../../../../main/src/
 import { Buffer } from 'buffer';
 import type { ContainerProviderConnection } from '@podman-desktop/api';
 import { providerInfos } from '../../stores/providers';
-import { beforeUpdate, onMount } from 'svelte';
+import { onMount } from 'svelte';
 import type { ProviderContainerConnectionInfo, ProviderInfo } from '../../../../main/src/plugin/api/provider-info';
 import { router } from 'tinro';
 import Modal from '../dialogs/Modal.svelte';
@@ -167,7 +167,7 @@ async function stopReceivingLogs(provider: ProviderInfo): Promise<void> {
 }
 </script>
 
-<Route path="/*" breadcrumb="{connectionName} Settings" let:meta>
+<Route path="/*" breadcrumb="{connectionName} Settings">
   <div class="flex flex-1 flex-col bg-charcoal-600 px-2">
     <div class="flex flex-row align-middle my-4">
       <div class="capitalize text-xl">{connectionName} settings</div>

packages/renderer/src/lib/preferences/PreferencesExtensionRendering.svelte

@@ -28,7 +28,7 @@ async function removeExtension() {
   </span>
   <div class="bg-charcoal-600 mt-5 rounded-md p-3">
     {#if extensionInfo}
-      <Route path="/*" breadcrumb="{extensionInfo.displayName}" let:meta>
+      <Route path="/*" breadcrumb="{extensionInfo.displayName}">
         <!-- Manage lifecycle-->
         <div class="flex pb-2">
           <div class="pr-2">Status</div>