Skip to content

Commit 7c3c5ee

Browse files
authored
feat: add tooltip with full path when cli tool is detected (podman-desktop#8330)
Signed-off-by: Denis Golovin <[email protected]>
1 parent 7783fe7 commit 7c3c5ee

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

packages/renderer/src/lib/preferences/PreferencesCliTool.spec.ts

+2
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ suite('CLI Tool item', () => {
117117
const versionElement = screen.getByLabelText('cli-version');
118118
expect(versionElement).toBeDefined();
119119
expect(versionElement.textContent).equal(`${cliToolInfoItem2.name} v${cliToolInfoItem2.version}`);
120+
const displayFullPathElement = screen.getByText('Path: path/to/tool-name-2');
121+
expect(displayFullPathElement).toBeInTheDocument();
120122
const updateLoadingButton = screen.getByRole('button', { name: 'Update' });
121123
expect(updateLoadingButton).toBeInTheDocument();
122124
expect(updateLoadingButton).toBeDisabled();

packages/renderer/src/lib/preferences/PreferencesCliTool.svelte

+8-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<script lang="ts">
22
import { faCircleArrowUp, faCircleXmark } from '@fortawesome/free-solid-svg-icons';
3-
import { Button } from '@podman-desktop/ui-svelte';
3+
import { Button, Tooltip } from '@podman-desktop/ui-svelte';
44
import Fa from 'svelte-fa';
55
66
import type { CliToolInfo } from '/@api/cli-tool-info';
@@ -114,11 +114,13 @@ function getLoggerHandler(_cliToolId: string): ConnectionCallback {
114114
{#if cliTool.version}
115115
<div
116116
class="flex flex-row justify-between align-center bg-[var(--pd-invert-content-bg)] p-2 rounded-lg min-w-[320px] w-fit">
117-
<div
118-
class="flex text-[var(--pd-invert-content-card-text)] font-bold text-sm items-center"
119-
aria-label="cli-version">
120-
{cliTool.name} v{cliTool.version}
121-
</div>
117+
<Tooltip area-label="cli-full-path" bottomRight={true} tip="Path: {cliTool.path}">
118+
<div
119+
class="flex text-[var(--pd-invert-content-card-text)] font-bold text-sm items-center"
120+
aria-label="cli-version">
121+
{cliTool.name} v{cliTool.version}
122+
</div>
123+
</Tooltip>
122124
{#if cliTool.newVersion}
123125
<Button
124126
type="link"

0 commit comments

Comments
 (0)