fix: remove redundant step completion check when onboarding gets started (podman-desktop#3783) (podman-desktop#3798)

* fix: remove redundant step completion check when how onboarding gets started (podman-desktop#3783)

Signed-off-by: lstocchi <[email protected]>

* fix: add missing catch

Signed-off-by: lstocchi <[email protected]>

---------

Signed-off-by: lstocchi <[email protected]>

Author: lstocchi

packages/renderer/src/lib/onboarding/Onboarding.svelte

@@ -41,7 +41,6 @@ let displayResetSetup = false;
 
 let executedCommands: string[] = [];
 
-let firstStart = true;
 /*
 $: enableNextButton = false;*/
 let onboardingUnsubscribe: Unsubscriber;
@@ -51,35 +50,19 @@ onMount(async () => {
   onboardingUnsubscribe = onboardingList.subscribe(onboardingItems => {
     if (!onboardings) {
       onboardings = onboardingItems.filter(o => extensionIds.find(extensionId => o.extension === extensionId));
-      if (!started) {
-        startOnboarding().then(isStartedByMe => {
-          if (isStartedByMe) {
-            assertStepCompleted().finally(() => (firstStart = false));
-          }
-        });
-      }
+      startOnboarding().catch((err: unknown) => console.warn(String(err)));
     }
   });
 
   // eslint-disable-next-line @typescript-eslint/no-misused-promises
-  contextsUnsubscribe = context.subscribe(async value => {
+  contextsUnsubscribe = context.subscribe(value => {
     globalContext = value;
-    if (!started) {
-      const isStartedByMe = await startOnboarding();
-      if (isStartedByMe) {
-        firstStart = false;
-        await assertStepCompleted();
-        return;
-      }
-    }
-    if (!firstStart) {
-      await assertStepCompleted();
-    }
+    startOnboarding().catch((err: unknown) => console.warn(String(err)));
   });
 });
 
 let started = false;
-async function startOnboarding(): Promise<boolean> {
+async function startOnboarding(): Promise<void> {
   if (!started && globalContext && onboardings) {
     started = true;
     if (isOnboardingsSetupCompleted(onboardings)) {
@@ -88,9 +71,7 @@ async function startOnboarding(): Promise<boolean> {
     } else {
       await restartSetup();
     }
-    return true;
   }
-  return false;
 }
 
 onDestroy(() => {
@@ -135,7 +116,6 @@ async function setActiveStep() {
       }
     }
   }
-
   // if it reaches this point it means that the onboarding is fully completed and the user is redirected to the dashboard
   router.goto($lastPage.path);
 }