Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop triggering E2E test in pull request. #383

Closed
Kesin11 opened this issue Mar 26, 2020 · 0 comments · Fixed by #385
Closed

Stop triggering E2E test in pull request. #383

Kesin11 opened this issue Mar 26, 2020 · 0 comments · Fixed by #385

Comments

@Kesin11
Copy link
Contributor

Kesin11 commented Mar 26, 2020

Problem

Previously, I introduced E2E test to check xcode-install can install Xcode correctly. #365
But, recently this test failed all pull request. (for example #378 #382 )

I read failed test log and found env variable XCODE_INSTALL_USER and XCODE_INSTALL_PASSWORD maybe null.
https://github.com/xcpretty/xcode-install/blob/master/.github/workflows/e2e.yml#L15-L16

Github Actions seems does not exposed "secrets" for action trigger by pull requests that from forked repository.
https://github.community/t5/GitHub-Actions/Make-secrets-available-to-builds-of-forks/td-p/30678

The test for "#372" is successful, but that's because the admin @milch created the pull request directly in this repository

Suggestion

In my opinion, E2E test should be stopped until Github Actions provides a feature that is a solution to this problem.
@Kesin11 Kesin11 mentioned this issue Apr 2, 2020
Merged
Kesin11 added a commit to Kesin11/xcode-install that referenced this issue Apr 4, 2020
@Kesin11
Revert "Add end to end test (xcpretty#365)"
b1386ea 
This reverts commit 18c402c.

fix xcpretty#383
@Kesin11 Kesin11 mentioned this issue Apr 4, 2020
Merged
@milch milch mentioned this issue Apr 18, 2020
Open
milch pushed a commit that referenced this issue Apr 18, 2020
@Kesin11
Revert e2e test and run spec on Github Actions (#385)
14cec8e 
* Revert "Add end to end test (#365)"

This reverts commit 18c402c.

fix #383

* Run spec and lint on github actions

* Fix rubocop violations

rubocop --auto-correct

* Skip a test randomely fail on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert e2e test and run spec on Github Actions Kesin11/xcode-install
1 participant
@Kesin11