Skip to content

Commit 22267b2

Browse files
committed
Update to latest Spring Boot version
1 parent 79235c0 commit 22267b2

File tree

6 files changed

+19
-27
lines changed

6 files changed

+19
-27
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 2.1.0
2+
* Updated to Spring Security 6.5+ / Spring Boot 3.5+
3+
* [``Extendable``] Backported some minor upstream changes
4+
15
# 2.0.1
26
* Migrated deployment to _Sonatype Maven Central Portal_ [#155](https://github.com/xdev-software/standard-maven-template/issues/155)
37
* Updated dependencies

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>software.xdev</groupId>
88
<artifactId>spring-security-advanced-authentication-ui-root</artifactId>
9-
<version>2.0.2-SNAPSHOT</version>
9+
<version>2.1.0-SNAPSHOT</version>
1010
<packaging>pom</packaging>
1111

1212
<organization>

spring-security-advanced-authentication-ui-demo/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
<parent>
88
<groupId>software.xdev</groupId>
99
<artifactId>spring-security-advanced-authentication-ui-root</artifactId>
10-
<version>2.0.2-SNAPSHOT</version>
10+
<version>2.1.0-SNAPSHOT</version>
1111
</parent>
1212

1313
<artifactId>spring-security-advanced-authentication-ui-demo</artifactId>
14-
<version>2.0.2-SNAPSHOT</version>
14+
<version>2.1.0-SNAPSHOT</version>
1515
<packaging>jar</packaging>
1616

1717
<organization>

spring-security-advanced-authentication-ui/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>software.xdev</groupId>
88
<artifactId>spring-security-advanced-authentication-ui</artifactId>
9-
<version>2.0.2-SNAPSHOT</version>
9+
<version>2.1.0-SNAPSHOT</version>
1010
<packaging>jar</packaging>
1111

1212
<name>spring-security-advanced-authentication-ui</name>

spring-security-advanced-authentication-ui/src/main/java/software/xdev/spring/security/web/authentication/ui/extendable/filters/ExtendableDefaultLoginPageGeneratingFilter.java

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,9 @@
2929
import jakarta.servlet.ServletResponse;
3030
import jakarta.servlet.http.HttpServletRequest;
3131
import jakarta.servlet.http.HttpServletResponse;
32-
import jakarta.servlet.http.HttpSession;
3332

34-
import org.springframework.security.core.AuthenticationException;
35-
import org.springframework.security.web.WebAttributes;
3633
import org.springframework.security.web.authentication.ui.DefaultLoginPageGeneratingFilter;
3734
import org.springframework.util.Assert;
38-
import org.springframework.util.StringUtils;
3935

4036
// CPD-OFF - Upstream copy
4137

@@ -369,8 +365,11 @@ protected String renderHeaders(final HttpServletRequest request)
369365
}
370366

371367
protected String renderFormLogin(
372-
final HttpServletRequest request, final boolean loginError, final boolean logoutSuccess,
373-
final String contextPath, final String errorMsg)
368+
final HttpServletRequest request,
369+
final boolean loginError,
370+
final boolean logoutSuccess,
371+
final String contextPath,
372+
final String errorMsg)
374373
{
375374
if(!this.formLoginEnabled)
376375
{
@@ -485,21 +484,9 @@ protected static String renderSaml2Row(final String contextPath, final String ur
485484

486485
protected String getLoginErrorMessage(final HttpServletRequest request)
487486
{
488-
final HttpSession session = request.getSession(false);
489-
if(session == null)
490-
{
491-
return "Invalid credentials";
492-
}
493-
if(!(session.getAttribute(WebAttributes.AUTHENTICATION_EXCEPTION)
494-
instanceof final AuthenticationException exception))
495-
{
496-
return "Invalid credentials";
497-
}
498-
if(!StringUtils.hasText(exception.getMessage()))
499-
{
500-
return "Invalid credentials";
501-
}
502-
return exception.getMessage();
487+
// Was changed in Spring Boot 3.5 to always return the same message
488+
// https://github.com/spring-projects/spring-security/commit/c4b223266c7c4713823634326705b586b47a58c4
489+
return "Invalid credentials";
503490
}
504491

505492
protected String renderHiddenInput(final String name, final String value)

spring-security-advanced-authentication-ui/src/main/java/software/xdev/spring/security/web/authentication/ui/extendable/filters/ExtendableDefaultLogoutPageGeneratingFilter.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@
2727
import jakarta.servlet.http.HttpServletResponse;
2828

2929
import org.springframework.core.log.LogMessage;
30+
import org.springframework.http.HttpMethod;
3031
import org.springframework.security.web.authentication.ui.DefaultLogoutPageGeneratingFilter;
31-
import org.springframework.security.web.util.matcher.AntPathRequestMatcher;
32+
import org.springframework.security.web.servlet.util.matcher.PathPatternRequestMatcher;
3233
import org.springframework.security.web.util.matcher.RequestMatcher;
3334
import org.springframework.util.Assert;
3435

@@ -41,7 +42,7 @@ public class ExtendableDefaultLogoutPageGeneratingFilter
4142
extends DefaultLogoutPageGeneratingFilter
4243
implements GeneratingFilterFillDataFrom<DefaultLogoutPageGeneratingFilter>, ExtendableDefaultPageGeneratingFilter
4344
{
44-
protected RequestMatcher matcher = new AntPathRequestMatcher("/logout", "GET");
45+
protected RequestMatcher matcher = PathPatternRequestMatcher.withDefaults().matcher(HttpMethod.GET, "/logout");
4546

4647
protected Function<HttpServletRequest, Map<String, String>> resolveHiddenInputs =
4748
request -> Collections.emptyMap();

0 commit comments

Comments
 (0)