-
-
Notifications
You must be signed in to change notification settings - Fork 488
Auto-update fbgemm to v1.4.1 #8534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the fbgemm package to version v1.4.1. The change correctly adds the new version and its hash. My review includes a comment on a potential build issue: an existing patch for versions >=1.1.0 will be applied to this new version, and it may not be compatible. This is a key point to check, especially if CI builds fail.
| add_urls("https://github.com/pytorch/FBGEMM/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/pytorch/FBGEMM.git", {submodules = false}) | ||
|
|
||
| add_versions("v1.4.1", "b6eebd5e7bc9f23903b89e8026458682f053045640b2cb8bee16fe51946a2f0c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing patch for versions >=1.1.0 (see line 16), dep-unbundle.patch, will be applied to this new version v1.4.1. This patch may be incompatible with the new version's source code, which could cause the build to fail. If build failures occur, a new, version-specific patch for v1.4.1 might be necessary.
New version of fbgemm detected (package version: v1.2.0, last github version: v1.4.1)