Skip to content

Commit 6926dc8

Browse files
committed
improve to select runtimes
1 parent fe2154b commit 6926dc8

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

xmake/modules/private/action/require/impl/package.lua

+7
Original file line numberDiff line numberDiff line change
@@ -1011,6 +1011,13 @@ function _load_package(packagename, requireinfo, opt)
10111011
-- check package configurations
10121012
_check_package_configurations(package)
10131013

1014+
-- we need to check package toolchains before on_load and select runtimes,
1015+
-- because we will call compiler-specific apis in on_load/on_fetch/find_package ..
1016+
--
1017+
-- @see https://github.com/xmake-io/xmake/pull/5466
1018+
-- https://github.com/xmake-io/xmake/issues/4596#issuecomment-2014528801
1019+
_check_package_toolchains(package)
1020+
10141021
-- we need to select package runtimes before computing buildhash
10151022
-- @see https://github.com/xmake-io/xmake/pull/4630#issuecomment-1910216561
10161023
_select_package_runtimes(package)

0 commit comments

Comments
 (0)