Skip to content

Commit 707bfc3

Browse files
authored
Merge pull request #5152 from ShifftC/dev
Update to #4800
2 parents d1c2095 + 56ea43c commit 707bfc3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

xmake/modules/package/tools/cmake.lua

+2-2
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,11 @@ function _get_vs_toolset(package)
298298
toolset_ver = "v" .. verinfo[1] .. (verinfo[2]:sub(1, 1) or "0")
299299
end
300300
end
301-
-- cmake does not support vs toolset v144 below 3.29.0, we can only use v143
301+
-- cmake does not support vs toolset v144 below 3.29.3, we can only use v143
302302
-- @see https://github.com/xmake-io/xmake/issues/4772
303303
if toolset_ver and toolset_ver >= "v144" then
304304
local cmake_version = _get_cmake_version()
305-
if cmake_version and cmake_version:le("3.29.0") then
305+
if cmake_version and cmake_version:le("3.29.3") then
306306
toolset_ver = "v143"
307307
end
308308
end

0 commit comments

Comments
 (0)