Add a new layout Columns #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This layout organizes windows in columns and allows to move/resize them in every directions.
geekosaur
requested changes
May 18, 2024
Contributor
geekosaur
left a comment
geekosaur
left a comment
There was a problem hiding this comment.
I'm sorry for the delay; my network's been out for two weeks.
geekosaur
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This layout organizes windows in columns and allows to move/resize them in every direction. This layout is showcased here: https://jeancharles.quillet.org/posts/2024-05-02-Columns-a-new-XMonad-layout.html
I was reluctant to send this layout in a PR because I'm not sure I'd have time to maintain it outside my main configuration. But I've been told that some people might be volunteers to maintain it 🙂 So here it is.
Something that might be annoying is that the parameter to toggle between wide screen and small screen is currently hardcoded. As the layout lives in my config, this is not a problem for me but it might be for others. I can make it configurable if needed tho.
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit, manually, ...) and concluded: I've been using this layout for more than one year now. It works fine for my usage. It has a few annoyances sometimes when using a tabbed sublayout but despite that it works great.
I updated the
CHANGES.mdfile