Skip to content

Commit 4037b94

Browse files
authored
remove AccessibleBuffer (#4427)
* remove AccessibleBuffer * rm more * Update src/browser/Terminal.ts * rm css
1 parent 9154831 commit 4037b94

File tree

7 files changed

+0
-158
lines changed

7 files changed

+0
-158
lines changed

css/xterm.css

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -151,29 +151,6 @@
151151
color: transparent;
152152
}
153153

154-
.xterm .xterm-accessible-buffer div {
155-
white-space: pre-wrap;
156-
}
157-
158-
.xterm .xterm-accessible-buffer {
159-
position: absolute;
160-
left: 0;
161-
top: 0;
162-
bottom: 0;
163-
right: 0;
164-
padding: .5em;
165-
background: #000;
166-
color: #fff;
167-
opacity: 0;
168-
overflow: scroll;
169-
overflow-x: hidden;
170-
}
171-
172-
.xterm .xterm-accessible-buffer:focus-within {
173-
opacity: 1;
174-
z-index: 20;
175-
}
176-
177154
.xterm .live-region {
178155
position: absolute;
179156
left: -9999px;

src/browser/AccessibleBuffer.ts

Lines changed: 0 additions & 101 deletions
This file was deleted.

src/browser/LocalizableStrings.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,3 @@ export let promptLabel = 'Terminal input';
1010

1111
// eslint-disable-next-line prefer-const
1212
export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read';
13-
14-
// eslint-disable-next-line prefer-const
15-
export let accessibleBuffer = 'Accessibility buffer';

src/browser/Terminal.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import * as Browser from 'common/Platform';
3333
import { addDisposableDomListener } from 'browser/Lifecycle';
3434
import * as Strings from 'browser/LocalizableStrings';
3535
import { AccessibilityManager } from './AccessibilityManager';
36-
import { AccessibleBuffer } from './AccessibleBuffer';
3736
import { ITheme, IMarker, IDisposable, ILinkProvider, IDecorationOptions, IDecoration } from 'xterm';
3837
import { DomRenderer } from 'browser/renderer/dom/DomRenderer';
3938
import { KeyboardResultType, CoreMouseEventType, CoreMouseButton, CoreMouseAction, ITerminalOptions, ScrollSource, IColorEvent, ColorIndex, ColorRequestType } from 'common/Types';
@@ -72,7 +71,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
7271
private _viewportElement: HTMLElement | undefined;
7372
private _helperContainer: HTMLElement | undefined;
7473
private _compositionView: HTMLElement | undefined;
75-
private _accessibleBuffer: AccessibleBuffer | undefined;
7674

7775
private _overviewRulerRenderer: OverviewRulerRenderer | undefined;
7876

@@ -193,13 +191,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
193191
}));
194192
}
195193

196-
public registerBufferElementProvider(bufferProvider: IBufferElementProvider): IDisposable {
197-
if (!this._accessibleBuffer) {
198-
throw new Error ('Cannot register buffer element provider when terminal has not been opened yet');
199-
}
200-
return this._accessibleBuffer.registerBufferElementProvider(bufferProvider);
201-
}
202-
203194
/**
204195
* Handle color event from inputhandler for OSC 4|104 | 10|110 | 11|111 | 12|112.
205196
* An event from OSC 4|104 may contain multiple set or report requests, and multiple
@@ -585,8 +576,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
585576
// Listen for mouse events and translate
586577
// them into terminal mouse protocols.
587578
this.bindMouse();
588-
589-
this._accessibleBuffer = this._instantiationService.createInstance(AccessibleBuffer, this);
590579
}
591580

592581
private _createRenderer(): IRenderer {
@@ -778,9 +767,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
778767
*/
779768
this.register(addDisposableDomListener(el, 'mousedown', (ev: MouseEvent) => {
780769
ev.preventDefault();
781-
if (this._accessibleBuffer?.isAccessibleBufferActive) {
782-
return;
783-
}
784770
this.focus();
785771

786772
// Don't send the mouse button to the pty if mouse events are disabled or

src/browser/Types.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ export interface IPublicTerminal extends IDisposable {
8080
refresh(start: number, end: number): void;
8181
clearTextureAtlas(): void;
8282
reset(): void;
83-
registerBufferElementProvider(bufferProvider: IBufferElementProvider): IDisposable;
8483
}
8584

8685
export type CustomKeyEventHandler = (event: KeyboardEvent) => boolean;

src/browser/public/Terminal.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,6 @@ export class Terminal implements ITerminalApi {
236236
public loadAddon(addon: ITerminalAddon): void {
237237
return this._addonManager.loadAddon(this, addon);
238238
}
239-
public registerBufferElementProvider(bufferProvider: IBufferElementProvider): IDisposable {
240-
return this._core.registerBufferElementProvider(bufferProvider);
241-
}
242239
public static get strings(): ILocalizableStrings {
243240
return Strings;
244241
}

typings/xterm.d.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -498,11 +498,6 @@ declare module 'xterm' {
498498
* being printed to the terminal when `screenReaderMode` is enabled.
499499
*/
500500
tooMuchOutput: string;
501-
502-
/**
503-
* The aria label for the accessibility buffer
504-
*/
505-
accessibleBuffer: string;
506501
}
507502

508503
/**
@@ -1108,14 +1103,6 @@ declare module 'xterm' {
11081103
* @param addon The addon to load.
11091104
*/
11101105
loadAddon(addon: ITerminalAddon): void;
1111-
1112-
/*
1113-
* Registers a buffer element provider which will provide a custom element to
1114-
* use in the terminal's accessible buffer. Using this an xterm.js embedder
1115-
* has full control over how the buffer is represented in the DOM.
1116-
* @param bufferElementProvider The buffer element provider.
1117-
*/
1118-
registerBufferElementProvider(bufferProvider: IBufferElementProvider): IDisposable;
11191106
}
11201107

11211108
/**

0 commit comments

Comments
 (0)