detect and remove inconsistency on load

Author: neihar

cloud/filestore/libs/vfs_fuse/directory_handles_storage.cpp

@@ -115,39 +115,82 @@ void TDirectoryHandlesStorage::ResetHandle(ui64 handleId)
 
 void TDirectoryHandlesStorage::LoadHandles(TDirectoryHandleMap& handles)
 {
-    TGuard guard(TableLock);
+    struct TUpdateVersionInfo
+    {
+        ui64 LargestUpdateVersion = 0;
+        ui64 ChunksCount = 0;
+        bool IsFirstChunkPresented = false;
+    };
+
+    TMap<ui64, TUpdateVersionInfo> updateVersionInfo;
+
+    {
+        TGuard guard(TableLock);
+
+        for (auto it = Table->begin(); it != Table->end(); ++it) {
+            TStringBuf record = *it;
+            if (record.empty()) {
+                STORAGE_TRACE(
+                    "bad record from storage during load directory handles");
+                continue;
+            }
 
-    for (auto it = Table->begin(); it != Table->end(); ++it) {
-        TStringBuf record = *it;
-        if (record.empty()) {
-            STORAGE_TRACE(
-                "bad record from storage during load directory handles");
-            continue;
-        }
+            auto [handleId, chunk] = DeserializeHandleChunk(record);
+
+            if (!handleId) {
+                STORAGE_DEBUG(
+                    "bad deserialize for record %lu from storage during load "
+                    "directory handles",
+                    it.GetIndex());
+                continue;
+            }
 
-        auto [handleId, chunk] = DeserializeHandleChunk(record);
+            if (!handles.contains(handleId)) {
+                handles[handleId] =
+                    std::make_shared<TDirectoryHandle>(chunk->Index);
+            }
 
-        if (!handleId) {
-            STORAGE_DEBUG(
-                "bad deserialize for record %lu from storage during load "
-                "directory handles",
-                it.GetIndex());
-            continue;
-        }
+            handles[handleId]->ConsumeChunk(*chunk);
 
-        if (!handles.contains(handleId)) {
-            handles[handleId] =
-                std::make_shared<TDirectoryHandle>(chunk->Index);
+            updateVersionInfo[handleId].ChunksCount++;
+            if (chunk->UpdateVersion >
+                updateVersionInfo[handleId].LargestUpdateVersion)
+            {
+                updateVersionInfo[handleId].LargestUpdateVersion =
+                    chunk->UpdateVersion;
+            }
+
+            if (chunk->UpdateVersion == 0) {
+                updateVersionInfo[handleId].IsFirstChunkPresented = true;
+                HandleIdToIndices[handleId].insert(
+                    HandleIdToIndices[handleId].begin(),
+                    it.GetIndex());
+            } else {
+                HandleIdToIndices[handleId].push_back(it.GetIndex());
+            }
         }
+    }
 
-        handles[handleId]->ConsumeChunk(*chunk);
+    for (auto [handleId, updateVersionInfo]: updateVersionInfo) {
+        if (!updateVersionInfo.IsFirstChunkPresented) {
+            ReportDirectoryHandlesStorageError(
+                TStringBuilder()
+                << "First chunk for handle " << handleId << " is missing");
 
-        if (chunk->UpdateVersion == 0) {
-            HandleIdToIndices[handleId].insert(
-                HandleIdToIndices[handleId].begin(),
-                it.GetIndex());
-        } else {
-            HandleIdToIndices[handleId].push_back(it.GetIndex());
+            RemoveHandle(handleId);
+            continue;
+        }
+
+        if (updateVersionInfo.ChunksCount !=
+            updateVersionInfo.LargestUpdateVersion + 1)
+        {
+            ReportDirectoryHandlesStorageError(
+                TStringBuilder()
+                << "Total chunks count " << updateVersionInfo.ChunksCount
+                << " is not equal to largest update version "
+                << updateVersionInfo.LargestUpdateVersion << " + 1");
+            ResetHandle(handleId);
+            continue;
         }
     }
 }