Skip to content

[Filestore] CompleteUnlinkNode gets called upon tablet reboot for UnlinkNodeInShardRequests generated upon RenameNode[InDestination] #6326

Description

@qkrorlqr

Here


and here
we correctly set shouldUnlockUponCompletion to false

but if the tablet restarts before completing the unlink stage then we replay the unlink request and forget to distinguish between the UnlinkNode->UnlinkNodeInShard and RenameNode[InDestination]->UnlinkNodeInShard cases:

GetFileSystem().GetDirectoryCreationInShardsEnabled();

this leads to incorrectly choosing this branch

and then we incorrectly report this crit event

ReportInvalidNodeRefUponCompleteUnlinkNode(

nothing really breaks, the state of the filesystem stays consistent, so it's not really a big-big deal but we still see false positive alerts and this is still a bug

Metadata

Metadata

Assignees

Labels

filestoreAdd this label to run only cloud/filestore build and tests on PR

Type

Fields

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions