Skip to content

Commit 1ad2ef1

Browse files
authored
fix(ClusterOverview): loading state (#2250)
1 parent 5a9b4a0 commit 1ad2ef1

File tree

3 files changed

+22
-9
lines changed

3 files changed

+22
-9
lines changed

src/containers/Cluster/ClusterOverview/ClusterOverview.scss

+5
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,9 @@
6767
min-width: 280px;
6868
height: 132px;
6969
}
70+
71+
&__card_collapsed {
72+
min-width: 120px;
73+
height: 28px;
74+
}
7075
}

src/containers/Cluster/ClusterOverview/ClusterOverview.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ function ClusterDashboard({collapsed, ...props}: ClusterDashboardProps) {
9191

9292
function ClusterDoughnuts({cluster, groupStats = {}, loading, collapsed}: ClusterOverviewProps) {
9393
if (loading) {
94-
return <ClusterDashboardSkeleton />;
94+
return <ClusterDashboardSkeleton collapsed={collapsed} />;
9595
}
9696
const metricsCards = [];
9797
if (isClusterInfoV2(cluster)) {

src/containers/Cluster/ClusterOverview/components/ClusterMetricsCard.tsx

+16-8
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,13 @@ interface ClusterMetricsCommonCardProps {
2828
collapsed?: boolean;
2929
}
3030

31-
export function ClusterMetricsCard({children, className}: ClusterMetricsCommonCardProps) {
31+
export function ClusterMetricsCard({
32+
children,
33+
className,
34+
collapsed,
35+
}: ClusterMetricsCommonCardProps) {
3236
return (
33-
<Flex gap="6" alignItems="center" className={b('card', className)}>
37+
<Flex gap="6" alignItems="center" className={b('card', {collapsed}, className)}>
3438
{children}
3539
</Flex>
3640
);
@@ -70,20 +74,24 @@ export function ClusterMetricsCardContent({
7074
);
7175
}
7276

73-
function ClusterMetricsCardSkeleton() {
77+
interface ClusterMetricsCardSkeletonProps {
78+
collapsed?: boolean;
79+
}
80+
81+
function ClusterMetricsCardSkeleton({collapsed}: ClusterMetricsCardSkeletonProps) {
7482
return (
75-
<ClusterMetricsCard className={b('skeleton-wrapper')}>
83+
<ClusterMetricsCard className={b('skeleton-wrapper')} collapsed={collapsed}>
7684
<Skeleton className={b('skeleton')} />
7785
</ClusterMetricsCard>
7886
);
7987
}
8088

81-
export function ClusterDashboardSkeleton() {
89+
export function ClusterDashboardSkeleton({collapsed}: ClusterMetricsCardSkeletonProps) {
8290
return (
8391
<React.Fragment>
84-
<ClusterMetricsCardSkeleton />
85-
<ClusterMetricsCardSkeleton />
86-
<ClusterMetricsCardSkeleton />
92+
<ClusterMetricsCardSkeleton collapsed={collapsed} />
93+
<ClusterMetricsCardSkeleton collapsed={collapsed} />
94+
<ClusterMetricsCardSkeleton collapsed={collapsed} />
8795
</React.Fragment>
8896
);
8997
}

0 commit comments

Comments
 (0)