feat: add setting to enable actions with directories from UI (#997)

Author: Raubzeug

src/containers/Tenant/Schema/SchemaTree/SchemaTree.tsx

@@ -5,9 +5,10 @@ import React from 'react';
 
 import {NavigationTree} from 'ydb-ui-components';
 
+import {USE_DIRECTORY_OPERATIONS} from '../../../../lib';
 import {schemaApi} from '../../../../store/reducers/schema/schema';
 import type {EPathType} from '../../../../types/api/schema';
-import {useQueryModes, useTypedDispatch} from '../../../../utils/hooks';
+import {useQueryModes, useSetting, useTypedDispatch} from '../../../../utils/hooks';
 import {isChildlessPathType, mapPathTypeToNavigationTreeType} from '../../utils/schema';
 import {getActions} from '../../utils/schemaActions';
 import {getControls} from '../../utils/schemaControls';
@@ -22,6 +23,7 @@ interface SchemaTreeProps {
 }
 
 export function SchemaTree(props: SchemaTreeProps) {
+    const [useDirectoryActions] = useSetting<boolean>(USE_DIRECTORY_OPERATIONS);
     const {rootPath, rootName, rootType, currentPath, onActivePathUpdate} = props;
     const dispatch = useTypedDispatch();
 
@@ -96,7 +98,9 @@ export function SchemaTree(props: SchemaTreeProps) {
                 getActions={getActions(dispatch, {
                     setActivePath: onActivePathUpdate,
                     setQueryMode,
-                    showCreateDirectoryDialog: handleOpenCreateDirectoryDialog,
+                    showCreateDirectoryDialog: useDirectoryActions
+                        ? handleOpenCreateDirectoryDialog
+                        : undefined,
                 })}
                 renderAdditionalNodeElements={getControls(dispatch, {
                     setActivePath: onActivePathUpdate,

src/containers/Tenant/utils/schemaActions.ts

@@ -29,7 +29,7 @@ import {
 interface ActionsAdditionalEffects {
     setQueryMode: (mode: QueryMode) => void;
     setActivePath: (path: string) => void;
-    showCreateDirectoryDialog: (path: string) => void;
+    showCreateDirectoryDialog?: (path: string) => void;
 }
 
 const bindActions = (
@@ -51,9 +51,11 @@ const bindActions = (
     };
 
     return {
-        createDirectory: () => {
-            showCreateDirectoryDialog(path);
-        },
+        createDirectory: showCreateDirectoryDialog
+            ? () => {
+                  showCreateDirectoryDialog(path);
+              }
+            : undefined,
         createTable: inputQuery(createTableTemplate, 'script'),
         createColumnTable: inputQuery(createColumnTableTemplate, 'script'),
         createAsyncReplication: inputQuery(createAsyncReplicationTemplate, 'script'),
@@ -99,7 +101,6 @@ export const getActions =
 
         const DIR_SET: ActionsSet = [
             [copyItem],
-            [{text: i18n('actions.createDirectory'), action: actions.createDirectory}],
             [
                 {text: i18n('actions.createTable'), action: actions.createTable},
                 {text: i18n('actions.createColumnTable'), action: actions.createColumnTable},
@@ -111,6 +112,11 @@ export const getActions =
                 {text: i18n('actions.createView'), action: actions.createView},
             ],
         ];
+        if (actions.createDirectory) {
+            DIR_SET.splice(1, 0, [
+                {text: i18n('actions.createDirectory'), action: actions.createDirectory},
+            ]);
+        }
         const TABLE_SET: ActionsSet = [
             [copyItem],
             [

src/containers/UserSettings/i18n/en.json

@@ -43,6 +43,8 @@
   "settings.useSeparateDisksPages.title": "Use separate PDisk and VDisk pages",
   "settings.useSeparateDisksPages.description": "Use separate pages instead of node structure tab",
 
+  "settings.useDirectoryOperations.title": "Enable operations with directories",
+
   "settings.useClusterBalancerAsBackend.title": "Use cluster balancer as backend",
   "settings.useClusterBalancerAsBackend.description": "By default random cluster node is used as backend. It causes saved links to become invalid after some time, when node is restarted. Using balancer as backend fixes it",
 

src/containers/UserSettings/settings.tsx

@@ -11,6 +11,7 @@ import {
     QUERY_USE_MULTI_SCHEMA_KEY,
     THEME_KEY,
     USE_CLUSTER_BALANCER_AS_BACKEND_KEY,
+    USE_DIRECTORY_OPERATIONS,
     USE_NODES_ENDPOINT_IN_DIAGNOSTICS_KEY,
     USE_PAGINATED_TABLES_KEY,
     USE_SEPARATE_DISKS_PAGES_KEY,
@@ -118,6 +119,11 @@ export const useSeparateDisksPagesSetting: SettingProps = {
     description: i18n('settings.useSeparateDisksPages.description'),
 };
 
+export const useDirectoryActionsSetting: SettingProps = {
+    settingKey: USE_DIRECTORY_OPERATIONS,
+    title: i18n('settings.useDirectoryOperations.title'),
+};
+
 export const useClusterBalancerAsBackendSetting: SettingProps = {
     settingKey: USE_CLUSTER_BALANCER_AS_BACKEND_KEY,
     title: i18n('settings.useClusterBalancerAsBackend.title'),
@@ -155,6 +161,7 @@ export const experimentsSection: SettingsSection = {
         usePaginatedTables,
         queryUseMultiSchemaSetting,
         useSeparateDisksPagesSetting,
+        useDirectoryActionsSetting,
     ],
 };
 export const devSettingsSection: SettingsSection = {

src/services/settings.ts

@@ -16,6 +16,7 @@ import {
     TENANT_INITIAL_PAGE_KEY,
     THEME_KEY,
     USE_CLUSTER_BALANCER_AS_BACKEND_KEY,
+    USE_DIRECTORY_OPERATIONS,
     USE_NODES_ENDPOINT_IN_DIAGNOSTICS_KEY,
     USE_PAGINATED_TABLES_KEY,
     USE_SEPARATE_DISKS_PAGES_KEY,
@@ -46,6 +47,7 @@ export const DEFAULT_USER_SETTINGS = {
     [AUTOCOMPLETE_ON_ENTER]: true,
     [IS_HOTKEYS_HELP_HIDDEN_KEY]: false,
     [AUTO_REFRESH_INTERVAL]: 0,
+    [USE_DIRECTORY_OPERATIONS]: false,
 } as const satisfies SettingsObject;
 
 class SettingsManager {

src/utils/constants.ts

@@ -142,3 +142,5 @@ export const AUTOCOMPLETE_ON_ENTER = 'autocompleteOnEnter';
 export const IS_HOTKEYS_HELP_HIDDEN_KEY = 'isHotKeysHelpHidden';
 
 export const USE_SEPARATE_DISKS_PAGES_KEY = 'useSeparateDisksPages';
+
+export const USE_DIRECTORY_OPERATIONS = 'useDirectoryOperations';