Merge pull request #1 from yewstack/test-pr

Fix benchmark action

Author: jstarry

.github/workflows/benchmark.yml

@@ -24,18 +24,30 @@ jobs:
           version: latest
           use-tool-cache: true
 
+      - uses: actions-rs/[email protected]
+        with:
+          crate: https
+          version: latest
+          use-tool-cache: true
+
+      - name: Server
+        run: http -p 8080 &
+
       - name: Setup Node
         uses: actions/setup-node@v1
         with:
           node-version: 12
 
       - name: Npm Install
-        run: npm install &&
-          (cd webdriver-ts && npm install) &&
+        run: |
+          npm install
+          (cd webdriver-ts && npm install)
           (cd webdriver-ts-results && npm install)
 
       - name: Build
-        run: npm run build-prod && (cd webdriver-ts && npm run build-prod)
+        run: |
+          npm run build-prod
+          (cd webdriver-ts && npm run build-prod)
 
       - name: Benchmark
         run: npm run bench -- --headless
@@ -44,11 +56,16 @@ jobs:
         run: npm run results
 
       - name: Build comment message
-        run: MSG=`(cd results_diff && cargo run)`
+        run: |
+          msg=$(cd results_diff && cargo run)
+          msg="${msg//'%'/'%25'}"
+          msg="${msg//$'\n'/'%0A'}"
+          msg="${msg//$'\r'/'%0D'}"
+          echo "::set-env name=MSG::$msg"
 
       - name: Comment PR
         uses: unsplash/comment-on-pr@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          msg: "$MSG"
+          msg: "${{ env.MSG }}"

README.md

@@ -58,22 +58,22 @@ https://chromedriver.chromium.org/downloads
 
 ### Setup local server
 
-You can use any server which properly handles the MIME type of wasm files. We recommend `miniserve`:
+You can use any server which properly handles the MIME type of wasm files. We recommend the `https` crate:
 
 ```
-cargo install miniserve
+cargo install https
 ```
 
-Start `miniserve` in the root directory
+Start server in the root directory
 ```
-miniserve .
+http -p 8080
 ```
 
 Verify that the server works:
 Try to open [http://localhost:8080/index.html](http://localhost:8080/index.html). If you see something like that you're on the right track:
 ![Index.html](images/index.png?raw=true "Index.html")
 
-Now open a new terminal window and keep `miniserve` running in background.
+Now open a new terminal window and keep `http` running in background.
 
 ### 2. Building and running a single framework
 

frameworks/keyed/yew/Cargo.toml

@@ -10,7 +10,7 @@ crate-type = ["cdylib"]
 [dependencies]
 rand = { version = "0.7.3", features = ["wasm-bindgen", "small_rng"] }
 wasm-bindgen = "0.2.62"
-yew = { git = "https://github.com/totorigolo/yew", branch = "bugfix/keyed-elements-reorder" }
+yew = { git = "https://github.com/jstarry/yew", branch = "keyed-list" }
 
 [profile.release]
 lto = true

frameworks/keyed/yew/bundled-dist/js-framework-benchmark-yew.js

@@ -203,7 +203,7 @@ function addBorrowedObject(obj) {
 }
 function __wbg_adapter_16(arg0, arg1, arg2) {
     try {
-        wasm.wasm_bindgen__convert__closures__invoke1_mut_ref__hcdc9d37da3e75d2c(arg0, arg1, addBorrowedObject(arg2));
+        wasm.wasm_bindgen__convert__closures__invoke1_mut_ref__h51d4f69569056647(arg0, arg1, addBorrowedObject(arg2));
     } finally {
         heap[stack_pointer++] = undefined;
     }
@@ -376,21 +376,25 @@ async function init(input) {
         var ret = getObject(arg0).nextSibling;
         return isLikeNone(ret) ? 0 : addHeapObject(ret);
     };
-    imports.wbg.__wbg_setnodeValue_ab4d09a5c9b583a3 = function(arg0, arg1, arg2) {
-        getObject(arg0).nodeValue = arg1 === 0 ? undefined : getStringFromWasm0(arg1, arg2);
-    };
-    imports.wbg.__wbg_createTextNode_756ffaca4044be42 = function(arg0, arg1, arg2) {
-        var ret = getObject(arg0).createTextNode(getStringFromWasm0(arg1, arg2));
-        return addHeapObject(ret);
-    };
     imports.wbg.__wbg_appendChild_3d4ec7dbf3472d31 = handleError(function(arg0, arg1) {
         var ret = getObject(arg0).appendChild(getObject(arg1));
         return addHeapObject(ret);
     });
+    imports.wbg.__wbg_firstChild_cc345cf09851e11c = function(arg0) {
+        var ret = getObject(arg0).firstChild;
+        return isLikeNone(ret) ? 0 : addHeapObject(ret);
+    };
     imports.wbg.__wbg_insertBefore_e617280513985f61 = handleError(function(arg0, arg1, arg2) {
         var ret = getObject(arg0).insertBefore(getObject(arg1), getObject(arg2));
         return addHeapObject(ret);
     });
+    imports.wbg.__wbg_setnodeValue_ab4d09a5c9b583a3 = function(arg0, arg1, arg2) {
+        getObject(arg0).nodeValue = arg1 === 0 ? undefined : getStringFromWasm0(arg1, arg2);
+    };
+    imports.wbg.__wbg_createTextNode_756ffaca4044be42 = function(arg0, arg1, arg2) {
+        var ret = getObject(arg0).createTextNode(getStringFromWasm0(arg1, arg2));
+        return addHeapObject(ret);
+    };
     imports.wbg.__wbg_namespaceURI_35b1c4eab9150629 = function(arg0, arg1) {
         var ret = getObject(arg1).namespaceURI;
         var ptr0 = isLikeNone(ret) ? 0 : passStringToWasm0(ret, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
@@ -447,8 +451,8 @@ async function init(input) {
     imports.wbg.__wbg_addEventListener_3526086a053a131e = handleError(function(arg0, arg1, arg2, arg3, arg4) {
         getObject(arg0).addEventListener(getStringFromWasm0(arg1, arg2), getObject(arg3), getObject(arg4));
     });
-    imports.wbg.__wbindgen_closure_wrapper1236 = function(arg0, arg1, arg2) {
-        var ret = makeMutClosure(arg0, arg1, 25, __wbg_adapter_16);
+    imports.wbg.__wbindgen_closure_wrapper1238 = function(arg0, arg1, arg2) {
+        var ret = makeMutClosure(arg0, arg1, 26, __wbg_adapter_16);
         return addHeapObject(ret);
     };
 

frameworks/keyed/yew/bundled-dist/js-framework-benchmark-yew_bg.wasm

@@ -42,6 +42,10 @@ fn main() {
     let full_length = max_benchmark_name_len + 35 + 4 * 3 + 2; // 35: sum of columns defined below, 3: padding, 2: sign
 
     println!("### Benchmark Report");
+    println!("- `wasm-bindgen`: the performance goal");
+    println!("- `baseline`: performance of `yew-baseline` (typically latest master)");
+    println!("- `update`: performance of `yew` (typically recent changes)");
+    println!("- `diff`: measures the improvement of `update` over the `baseline`");
     println!("```diff");
     println!("@@ {:^1$} @@", "Performance Diff", full_length - 6);
     println!();