-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
wip: add a screenshot test for svg rendering #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Screenshot code is adapted from https://github.com/xataio/screenshot/ |
| { | ||
| "goog:chromeOptions": { | ||
| "args": [ | ||
| "--use-fake-ui-for-media-stream", | ||
| "--use-fake-device-for-media-stream" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other options can be found here: https://peter.sh/experiments/chromium-command-line-switches/
|
Visit the preview URL for this PR (updated for commit b6de2dd): https://yew-rs-api--pr3895-screenshot-a3qpjxg5.web.app (expires Sun, 17 Aug 2025 14:56:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
3f36350 to
b6de2dd
Compare
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
Description
Current master branch renders a white screen (at least on Chrome) because it converts svg element names to lower case:
here is a minimal repo https://github.com/Madoshakalaka/svg-dropshadow
Trying to add a test with screenshot to confirm this.
But I keep getting a green pacman
to reproduce
chromedriverit will print a base64 pacman image somehow